<div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif">This looked good to me, just a couple of minor comments (about docstrings and their format) and one question that I left. Once this is rebased on the newer version of my patch it should be good.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 17, 2023 at 7:07 AM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Add abstractions for traffic generator split into those that can and<br>
can't capture traffic.<br>
<br>
The Scapy implementation uses an XML-RPC server for remote control. This<br>
requires an interactive session to add Scapy funcions to the server. The<br>
interactive session code is based on another patch [0].<br>
<br>
The basic test case is there to showcase the Scapy implementation - it<br>
sends just one UDP packet and verifies it on the other end.<br>
<br>
[0]: <a href="http://patches.dpdk.org/project/dpdk/patch/20230713165347.21997-3-jspewock@iol.unh.edu/" rel="noreferrer" target="_blank">http://patches.dpdk.org/project/dpdk/patch/20230713165347.21997-3-jspewock@iol.unh.edu/</a><br>
<br>
Juraj Linkeš (6):<br>
dts: add scapy dependency<br>
dts: add traffic generator config<br>
dts: traffic generator abstractions<br>
dts: add python remote interactive shell<br>
dts: scapy traffic generator implementation<br>
dts: add basic UDP test case<br>
<br>
doc/guides/tools/dts.rst | 31 ++<br>
dts/conf.yaml | 27 +-<br>
dts/framework/config/__init__.py | 115 ++++---<br>
dts/framework/config/conf_yaml_schema.json | 32 +-<br>
dts/framework/dts.py | 65 ++--<br>
dts/framework/remote_session/__init__.py | 3 +-<br>
dts/framework/remote_session/linux_session.py | 96 ++++++<br>
dts/framework/remote_session/os_session.py | 75 +++--<br>
.../remote_session/remote/__init__.py | 1 +<br>
.../remote/interactive_shell.py | 18 +-<br>
.../remote_session/remote/python_shell.py | 24 ++<br>
.../remote_session/remote/testpmd_shell.py | 33 +-<br>
dts/framework/test_suite.py | 221 ++++++++++++-<br>
dts/framework/testbed_model/__init__.py | 1 +<br>
.../capturing_traffic_generator.py | 135 ++++++++<br>
dts/framework/testbed_model/hw/port.py | 60 ++++<br>
dts/framework/testbed_model/node.py | 64 +++-<br>
dts/framework/testbed_model/scapy.py | 290 ++++++++++++++++++<br>
dts/framework/testbed_model/sut_node.py | 52 ++--<br>
dts/framework/testbed_model/tg_node.py | 99 ++++++<br>
.../testbed_model/traffic_generator.py | 72 +++++<br>
dts/framework/utils.py | 13 +<br>
dts/poetry.lock | 21 +-<br>
dts/pyproject.toml | 1 +<br>
dts/tests/TestSuite_os_udp.py | 45 +++<br>
dts/tests/TestSuite_smoke_tests.py | 6 +-<br>
26 files changed, 1434 insertions(+), 166 deletions(-)<br>
create mode 100644 dts/framework/remote_session/remote/python_shell.py<br>
create mode 100644 dts/framework/testbed_model/capturing_traffic_generator.py<br>
create mode 100644 dts/framework/testbed_model/hw/port.py<br>
create mode 100644 dts/framework/testbed_model/scapy.py<br>
create mode 100644 dts/framework/testbed_model/tg_node.py<br>
create mode 100644 dts/framework/testbed_model/traffic_generator.py<br>
create mode 100644 dts/tests/TestSuite_os_udp.py<br>
<br>
-- <br>
2.34.1<br>
<br>
</blockquote></div>