<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:PMingLiU;
panose-1:2 1 6 1 0 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@PMingLiU";
panose-1:2 1 6 1 0 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
span.EmailStyle18
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi all,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The API “rte_event_eth_rx_adapter_create_with_params()” is an extension to rte_event_eth_rx_adapter_create() with additional adapter configuration params structure.<o:p></o:p></p>
<p class="MsoNormal">There is no equivalent API existing today for “rte_event_eth_rx_adapter_create_ext()” API. We may need to have one more adapter create API for this.<o:p></o:p></p>
<p class="MsoNormal">That makes so many Adapter create APIs and will be confusing for the user.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> I am proposing the following changes to the Rx adapter create APIs which will consolidate the create APIs to 2 in number with all possible combinations.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<table class="MsoNormalTable" border="0" cellspacing="0" cellpadding="0" width="1133" style="width:850.0pt;border-collapse:collapse">
<tbody>
<tr>
<td width="600" valign="top" style="width:6.25in;border:solid #A3A3A3 1.0pt;background:#00C7FD;padding:2.0pt 3.0pt 2.0pt 3.0pt">
<p class="MsoNormal"><b><span style="color:black">Current RX Adapter create APIs</span></b><o:p></o:p></p>
</td>
<td width="532" valign="top" style="width:399.0pt;border:solid #A3A3A3 1.0pt;border-left:none;background:#00C7FD;padding:2.0pt 3.0pt 2.0pt 3.0pt">
<p class="MsoNormal"><b><span style="color:black">Proposed changes</span></b><o:p></o:p></p>
</td>
</tr>
<tr>
<td width="600" valign="top" style="width:6.25in;border:solid #A3A3A3 1.0pt;border-top:none;padding:2.0pt 3.0pt 2.0pt 3.0pt">
<p class="MsoNormal"> int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,<o:p></o:p></p>
<p class="MsoNormal"> rte_event_eth_rx_adapter_conf_cb conf_cb,<o:p></o:p></p>
<p class="MsoNormal"> void *conf_arg)<o:p></o:p></p>
</td>
<td width="532" valign="top" style="width:399.0pt;border-top:none;border-left:none;border-bottom:solid #A3A3A3 1.0pt;border-right:solid #A3A3A3 1.0pt;padding:2.0pt 3.0pt 2.0pt 3.0pt">
<p class="MsoNormal"> int rte_event_eth_rx_adapter_create_ext(uint8_t id, uint8_t dev_id,<o:p></o:p></p>
<p class="MsoNormal"> rte_event_eth_rx_adapter_conf_cb conf_cb,<o:p></o:p></p>
<p class="MsoNormal"> void *conf_arg,<o:p></o:p></p>
<p class="MsoNormal"> <b><span style="background:yellow;mso-highlight:yellow">struct rte_event_eth_rx_adapter_params *rxa_params)</span></b><o:p></o:p></p>
</td>
</tr>
<tr>
<td width="600" valign="top" style="width:6.25in;border:solid #A3A3A3 1.0pt;border-top:none;padding:2.0pt 3.0pt 2.0pt 3.0pt">
<p class="MsoNormal"> int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,<o:p></o:p></p>
<p class="MsoNormal"> struct rte_event_port_conf *port_config)<o:p></o:p></p>
</td>
<td width="532" valign="top" style="width:399.0pt;border-top:none;border-left:none;border-bottom:solid #A3A3A3 1.0pt;border-right:solid #A3A3A3 1.0pt;padding:2.0pt 3.0pt 2.0pt 3.0pt">
<p class="MsoNormal"> int rte_event_eth_rx_adapter_create(uint8_t id, uint8_t dev_id,<o:p></o:p></p>
<p class="MsoNormal"> struct rte_event_port_conf *port_config,<o:p></o:p></p>
<p class="MsoNormal"> <b><span style="background:yellow;mso-highlight:yellow">struct rte_event_eth_rx_adapter_params *rxa_params)</span></b><o:p></o:p></p>
</td>
</tr>
<tr>
<td width="600" valign="top" style="width:6.25in;border:solid #A3A3A3 1.0pt;border-top:none;padding:2.0pt 3.0pt 2.0pt 3.0pt">
<p class="MsoNormal"> int rte_event_eth_rx_adapter_create_with_params(uint8_t id, uint8_t dev_id,<o:p></o:p></p>
<p class="MsoNormal"> struct rte_event_port_conf *port_config,<o:p></o:p></p>
<p class="MsoNormal"> struct rte_event_eth_rx_adapter_params *rxa_params)<o:p></o:p></p>
</td>
<td width="532" valign="top" style="width:399.0pt;border-top:none;border-left:none;border-bottom:solid #A3A3A3 1.0pt;border-right:solid #A3A3A3 1.0pt;padding:2.0pt 3.0pt 2.0pt 3.0pt">
<p class="MsoNormal"> Will be deprecated.<o:p></o:p></p>
</td>
</tr>
</tbody>
</table>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The applications that are currently using rte_event_eth_rx_adapter_create_ext() or rte_event_eth_rx_adapter_create() APIs for creating Rx adapter can pass NULL argument for the<o:p></o:p></p>
<p class="MsoNormal">Newly added argument which will behave same as before.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Let me know your comments for this change.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Patchwork link:<o:p></o:p></p>
<p class="MsoNormal"><a href="https://patches.dpdk.org/project/dpdk/patch/20230801094004.51939-1-s.v.naga.harish.k@intel.com/">https://patches.dpdk.org/project/dpdk/patch/20230801094004.51939-1-s.v.naga.harish.k@intel.com/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">-Harish<o:p></o:p></p>
</div>
</body>
</html>