<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="en-IT" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Sounds good to me<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div>
<div>
<p class="MsoNormal"><span lang="EN-US" style="font-size:11.0pt;mso-fareast-language:EN-US">Thanks<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US">EA</span><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;mso-fareast-language:EN-US"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="mso-margin-top-alt:0cm;margin-right:0cm;margin-bottom:12.0pt;margin-left:36.0pt">
<b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">David Marchand <david.marchand@redhat.com><br>
<b>Date: </b>Friday, 29 September 2023 at 17:00<br>
<b>To: </b>Elena Agostini <eagostini@nvidia.com><br>
<b>Cc: </b>dev@dpdk.org <dev@dpdk.org>, Levend Sayar <levendsayar@gmail.com>, Aaron Conole <aconole@redhat.com>, romein@astron.nl <romein@astron.nl><br>
<b>Subject: </b>Re: [PATCH] gpu/cuda: fix getenv related build error<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:0cm;margin-right:0cm;margin-bottom:12.0pt;margin-left:36.0pt">
<span style="font-size:11.0pt">External email: Use caution opening links or attachments<br>
<br>
<br>
On Thu, Aug 3, 2023 at 6:25 PM Levend Sayar <levendsayar@gmail.com> wrote:<br>
><br>
> If gdrapi.h is available, meson sets DRIVERS_GPU_CUDA_GDRCOPY_H as 1.<br>
> This causes gdrcopy.c build to give an error;<br>
> because compiler can not find signature of getenv.<br>
> stdlib.h is included for the definition of getenv function.<br>
><br>
<br>
There was a bug report for this issue:<br>
Bugzilla ID: 1133<br>
<br>
> Fixes: ca12f5e8a7db ("gpu/cuda: mark unused GDRCopy functions parameters")<br>
<br>
It is probably worth backporting:<br>
Cc: stable@dpdk.org<br>
<br>
><br>
> Signed-off-by: Levend Sayar <levendsayar@gmail.com><br>
<br>
Elena, this is a quick one, review please.<br>
<br>
<br>
--<br>
David Marchand<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>