<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:-apple-system;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi DPDK,<o:p></o:p></p>
<p class="MsoNormal"> When DPDK is built in debug mode by setting RTE_LOG_DP_LEVEL=RTE_LOG_DEBUG, l3fwd build fails due to<o:p></o:p></p>
<p class="MsoNormal">static inline functions <span style="font-size:10.5pt;font-family:-apple-system;color:#1F2328;background:white">
dump_acl4_rule(), dump_acl6_rule() defined in l3fwd_acl.c are called from l3fwd_acl_scalar.h:l3fwd_acl_send_packets() and
<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:-apple-system;color:#1F2328;background:white">other typo errors as below.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:10.5pt;font-family:-apple-system;color:#1F2328;background:white">Can I post a patch to fix the below l3fwd build errors?</span><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl_scalar.h: In function 'l3fwd_acl_send_packets':<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl_scalar.h:96:34: error: invalid operands to binary & (have 'uint32_t *' {aka 'unsigned int *'} and 'unsigned int')<o:p></o:p></p>
<p class="MsoNormal"> 96 | if ((res & ACL_DENY_SIGNATURE) != 0) {
<o:p></o:p></p>
<p class="MsoNormal"> | ^<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: warning: implicit declaration of function 'dump_acl4_rule' [-Wimplicit-function-declaration]<o:p></o:p></p>
<p class="MsoNormal"> 98 | dump_acl4_rule(pkts[i], res[i]);<o:p></o:p></p>
<p class="MsoNormal"> | ^~~~~~~~~~~~~~<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: warning: nested extern declaration of 'dump_acl4_rule' [-Wnested-externs]<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl_scalar.h:99:62: error: 'pkt' undeclared (first use in this function); did you mean 'pkts'?<o:p></o:p></p>
<p class="MsoNormal"> 99 | else if (RTE_ETH_IS_IPV6_HDR(pkt[i]->packet_type))<o:p></o:p></p>
<p class="MsoNormal"> | ^~~<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">In file included from ../../examples/l3fwd/l3fwd_acl.c:268:<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl_scalar.h:100:41: warning: implicit declaration of function 'dump_acl6_rule' [-Wimplicit-function-declaration]<o:p></o:p></p>
<p class="MsoNormal"> 100 | dump_acl6_rule(pkt[i], res[i]);<o:p></o:p></p>
<p class="MsoNormal"> | ^~~~~~~~~~~~~~<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl_scalar.h:100:41: warning: nested extern declaration of 'dump_acl6_rule' [-Wnested-externs]<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c: At top level:<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c:870:1: warning: conflicting types for 'dump_acl4_rule'; have 'void(struct rte_mbuf *, uint32_t)' {aka 'void(struct rte_mbuf *, unsigned int)'}<o:p></o:p></p>
<p class="MsoNormal"> 870 | dump_acl4_rule(struct rte_mbuf *m, uint32_t sig)<o:p></o:p></p>
<p class="MsoNormal"> | ^~~~~~~~~~~~~~<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c:870:1: error: static declaration of 'dump_acl4_rule' follows non-static declaration<o:p></o:p></p>
<p class="MsoNormal">In file included from ../../examples/l3fwd/l3fwd_acl.c:268:<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl_scalar.h:98:41: note: previous implicit declaration of 'dump_acl4_rule' with type 'void(struct rte_mbuf *, uint32_t)' {aka 'void(struct rte_mbuf *, unsigned int)'}<o:p></o:p></p>
<p class="MsoNormal"> 98 | dump_acl4_rule(pkts[i], res[i]);<o:p></o:p></p>
<p class="MsoNormal"> | ^~~~~~~~~~~~~~<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c: In function 'dump_acl4_rule':<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c:878:61: warning: passing argument 2 of 'inet_ntop' makes pointer from integer without a cast [-Wint-conversion]<o:p></o:p></p>
<p class="MsoNormal"> 878 | printf("Packet Src:%s ", inet_ntop(AF_INET, ipv4_hdr->src_addr,<o:p></o:p></p>
<p class="MsoNormal"> | ~~~~~~~~^~~~~~~~~~<o:p></o:p></p>
<p class="MsoNormal"> | |<o:p></o:p></p>
<p class="MsoNormal"> | rte_be32_t {aka unsigned int}<o:p></o:p></p>
<p class="MsoNormal">In file included from ../../lib/net/rte_ip.h:26,<o:p></o:p></p>
<p class="MsoNormal"> from ../../lib/ethdev/rte_flow.h:24,<o:p></o:p></p>
<p class="MsoNormal"> from ../../lib/ethdev/rte_eth_ctrl.h:11,<o:p></o:p></p>
<p class="MsoNormal"> from ../../lib/ethdev/rte_ethdev.h:1492,<o:p></o:p></p>
<p class="MsoNormal"> from ../../examples/l3fwd/l3fwd.h:8,<o:p></o:p></p>
<p class="MsoNormal"> from ../../examples/l3fwd/l3fwd_acl.c:5:<o:p></o:p></p>
<p class="MsoNormal">/tools/AGRreleases/yocto/snr/snr_h_60c911d4/5.10/tools/sysroots/snr-64-intelaxxia-linux/usr/include/arpa/inet.h:64:64: note: expected 'const void * restrict' but argument is of type 'rte_be32_t' {aka 'unsigned int'}<o:p></o:p></p>
<p class="MsoNormal"> 64 | extern const char *inet_ntop (int __af, const void *__restrict __cp,<o:p></o:p></p>
<p class="MsoNormal"> | ~~~~~~~~~~~~~~~~~~~~~~~^~~~<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c:880:54: warning: passing argument 2 of 'inet_ntop' makes pointer from integer without a cast [-Wint-conversion]<o:p></o:p></p>
<p class="MsoNormal"> 880 | printf("Dst:%s ", inet_ntop(AF_INET, ipv4_hdr->dst_addr,<o:p></o:p></p>
<p class="MsoNormal"> | ~~~~~~~~^~~~~~~~~~<o:p></o:p></p>
<p class="MsoNormal"> | |<o:p></o:p></p>
<p class="MsoNormal"> | rte_be32_t {aka unsigned int}<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c: In function 'dump_acl6_rule':<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c:914:39: error: 'struct <anonymous>' has no member named 'rule_ipv6'<o:p></o:p></p>
<p class="MsoNormal"> 914 | print_one_ipv6_rule(acl_config.rule_ipv6 + offset, 1);<o:p></o:p></p>
<p class="MsoNormal"> | ^<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c: In function 'setup_acl':<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c:985:19: error: 'struct <anonymous>' has no member named 'rule_ipv4'<o:p></o:p></p>
<p class="MsoNormal"> 985 | acl_config.rule_ipv4 = (struct acl4_rule *)acl_base_ipv4;<o:p></o:p></p>
<p class="MsoNormal"> | ^<o:p></o:p></p>
<p class="MsoNormal">../../examples/l3fwd/l3fwd_acl.c:986:19: error: 'struct <anonymous>' has no member named 'rule_ipv6'<o:p></o:p></p>
<p class="MsoNormal"> 986 | acl_config.rule_ipv6 = (struct acl6_rule *)acl_base_ipv6;<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Ganapati<o:p></o:p></p>
</div>
</body>
</html>