<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-IE" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> <p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <p class="MsoNormal"><span style="mso-fareast-language:EN-US"><o:p> </o:p></span></p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> <p class="MsoNormal"><b><span lang="EN-US">From:</span></b><span lang="EN-US"> Maryam Tahhan <mtahhan@redhat.com> <br> <b>Sent:</b> Friday, December 1, 2023 10:20 AM<br> <b>To:</b> Koikkara Reeny, Shibin <shibin.koikkara.reeny@intel.com>; ferruh.yigit@amd.com; stephen@networkplumber.org; lihuisong@huawei.com; fengchengwen@huawei.com; liuyonglong@huawei.com<br> <b>Cc:</b> dev@dpdk.org<br> <b>Subject:</b> Re: [v1] net/af_xdp: enable a sock path alongside use_cni<o:p></o:p></span></p> </div> </div> <p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">[snip] <o:p></o:p></p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <pre> <o:p></o:p></pre> <pre> Prerequisites<o:p></o:p></pre> <pre>@@ -224,7 +225,6 @@ Howto run dpdk-testpmd with CNI plugin:<o:p></o:p></pre> <pre> capabilities:<o:p></o:p></pre> <pre> add:<o:p></o:p></pre> <pre> - CAP_NET_RAW<o:p></o:p></pre> <pre>- - CAP_BPF<o:p></o:p></pre> </blockquote> </blockquote> <pre> <o:p></o:p></pre> <pre>Why the CAP_BPF is removed?<o:p></o:p></pre> </blockquote> <p> <o:p></o:p></p> <p>Good question. It's removed because in our case CAP_BPF is only needed when we want to load or unload the XDP program on the interface inside the Pod. In our case the CNI is loading the xdp program on the interface and then we are doing a handshake to get the xskmap file descriptor and so we don't need the CAP_BPF. <br> <br> You will find a detailed listing of the permissions used at different stages when utilizing an XDP prog in this article <a href="https://next.redhat.com/2023/07/18/using-ebpf-in-unprivileged-pods/">https://next.redhat.com/2023/07/18/using-ebpf-in-unprivileged-pods/</a> <br> <br> I'm currently also working on enabling pinned map sharing with the af_xdp vdev eal arguments so we can integrate with bpfman for centralized BPF program lifecycle management [currently under test]. <o:p></o:p></p> <p> <o:p></o:p></p> <p>Correct me if I am wrong, Don’t we still need the CAP_BPF for bpf operations? <o:p> </o:p></p> </div> </div> </blockquote> <p>The only BPF operation in the Pod (when using the AF_XDP CNI) is interacting with the BPF maps via bpf_map_update_elem(). <o:p></o:p></p> <p>There's no BPF load/unload operations when you are using the AF_XDP DP and CNI (it does this for you) similar to what bpfman is doing in [1]. To interact with BPF maps you don't need CAP_BPF since the 5.19 Kernel please see [2], in addition to the previous links. In other words the only time you should need cap_bpf to access a map is if your kernel is <= 5.18. Which was the note I was referring to when I said I would update the documentation.<o:p></o:p></p> <p>=======<o:p></o:p></p> <p>Please add this also to the V2.<o:p></o:p></p> <p>I've tested this patch in pod on Fedora 38 Kernel version: 6.5.12-200.fc38.x86_64 and there you don't need CAP_BPF.<o:p></o:p></p> <p>Additionally Ubuntu 22.04 LTS is now shipping with a 6.2 Kernel [3], so you will not need it there either.<o:p></o:p></p> <p>We don't want to give the pods more permissions than they need. CAP_BPF is in IMO an elevated permission. <o:p></o:p></p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <p>If CAP_BPF is not need so do we need the CAP_NET_RAW also?<o:p></o:p></p> </div> </div> </blockquote> <p>You need the CAP_NET_RAW to create the AF_XDP socket. <o:p></o:p></p> <p class="MsoNormal"><br> <br> <br> <o:p></o:p></p> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt"> <div> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">[snip]<o:p></o:p></p> </div> </div> </blockquote> <p class="MsoNormal"><o:p> </o:p></p> <p>[1] <a href="https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=c8644cd0efe7"> https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git/commit/?id=c8644cd0efe7</a> <o:p></o:p></p> <p>[2] <a href="https://bpfd.dev/developer-guide/linux-capabilities/#removing-cap_bpf-from-bpfman-clients"> https://bpfd.dev/developer-guide/linux-capabilities/#removing-cap_bpf-from-bpfman-clients</a><o:p></o:p></p> <p>[3] <a href="https://tuxcare.com/blog/ubuntu-22-04-3-is-here-with-linux-kernel-6-2/#:~:text=Initially%20released%20on%20April%2021,Ubuntu%2023.04%20(Lunar%20Lobster)"> https://tuxcare.com/blog/ubuntu-22-04-3-is-here-with-linux-kernel-6-2/#:~:text=Initially%20released%20on%20April%2021,Ubuntu%2023.04%20(Lunar%20Lobster)</a>.<o:p></o:p></p> </div> </div> </body> </html>