<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<p style="font-family:Arial;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - General]<br>
</p>
<br>
<div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
Thanks Bruce & Cristian for the comments. </div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">An increase seems ok to me, but is an 8x increase really necessary? If</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">lines in the config files are over 1k in size, then it implies that some</span></div>
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">other mechanism would surely be better for configuration.</span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Can we make do with an increase to 512 only?</span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">VV> We encountered this issue
</span><span style="letter-spacing: normal; font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; font-weight: 400; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);"><a href="https://bugs.dpdk.org/show_bug.cgi?id=1333" id="OWA49c8656a-a8a2-ee23-2bec-72c20a4c7e39" class="OWAAutoLink" data-auth="NotApplicable" data-loopstyle="linkonly" style="margin: 0px; text-align: left; background-color: rgb(255, 255, 255);">https://bugs.dpdk.org/show_bug.cgi?id=1333</a></span><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"> trying
to use multiple queue with DSA. But I hear you 256 to 2048 is big jump.</span></div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof"><span style="letter-spacing: normal; font-family: "Segoe UI Web (West European)", "Segoe UI", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; font-weight: 400; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);">Happy
to compromise with 1K.</span><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><br>
</span></div>
<div class="elementToProof">
<div><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);"></span>VV>
Sure let me update this is v2.</span></div>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Since there is a ABI breakage,
<a href="https://patchwork.dpdk.org/project/dpdk/patch/20231206112952.1588-1-vipin.varghese@amd.com/" id="OWAc67944c9-3835-74e0-dac2-9d12a2b744f4" class="OWAAutoLink" data-loopstyle="linkonly">
https://patchwork.dpdk.org/project/dpdk/patch/20231206112952.1588-1-vipin.varghese@amd.com/</a> I will re work and share v2.</span></div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Dumitrescu, Cristian <cristian.dumitrescu@intel.com><br>
<b>Sent:</b> 06 December 2023 19:04<br>
<b>To:</b> Richardson, Bruce <bruce.richardson@intel.com>; Varghese, Vipin <Vipin.Varghese@amd.com><br>
<b>Cc:</b> dev@dpdk.org <dev@dpdk.org>; Yigit, Ferruh <Ferruh.Yigit@amd.com><br>
<b>Subject:</b> RE: [PATCH] cfgfile: increase value length</span>
<div> </div>
</div>
<div><span style="font-size: 11pt;">Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.<br>
<br>
<br>
> -----Original Message-----<br>
> From: Richardson, Bruce <bruce.richardson@intel.com><br>
> Sent: Wednesday, December 6, 2023 1:22 PM<br>
> To: Vipin Varghese <vipin.varghese@amd.com><br>
> Cc: dev@dpdk.org; Dumitrescu, Cristian <cristian.dumitrescu@intel.com>;<br>
> Ferruh Yigit <ferruh.yigit@amd.com><br>
> Subject: Re: [PATCH] cfgfile: increase value length<br>
><br>
> On Wed, Dec 06, 2023 at 04:59:52PM +0530, Vipin Varghese wrote:<br>
> > The default value for CFG_VALUE_LEN is set to 256 characters.<br>
> > This limits the parsing for longer strings in configuration file.<br>
> > Setting the default to 2048 characters increases the value array<br>
> > size in `struct rte_cfgfile_entry`.<br>
> ><br>
> > Files using cfgfile library are<br>
> > 1. drivers/net/mvpp2/<br>
> > 2. app/test-dma-perf/<br>
> > 3. app/test/<br>
> > 4. examples/qos_sched/<br>
> ><br>
> > The structure `rte_cfgfile_entry` is not included in DPDK libraries.<br>
> > Modifying from 256 to 2048 allows `app/test-dma-perf/main.c` helps to<br>
> > parse longer string as shared in<br>
> <a href="https://bugs.dpdk.org/show_bug.cgi?id=1333" id="OWA6a4f2a8a-0965-c3b3-f51d-df441439fb39" class="OWAAutoLink" data-auth="NotApplicable" data-loopstyle="linkonly">
https://bugs.dpdk.org/show_bug.cgi?id=1333</a><br>
> ><br>
> > Signed-off-by: Vipin Varghese <vipin.varghese@amd.com><br>
> > Suggested-by: Ferruh Yigit <ferruh.yigit@amd.com><br>
> > ---<br>
> > lib/cfgfile/rte_cfgfile.h | 2 +-<br>
> > 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> ><br>
> > diff --git a/lib/cfgfile/rte_cfgfile.h b/lib/cfgfile/rte_cfgfile.h<br>
> > index 232c65c77b..401353c44e 100644<br>
> > --- a/lib/cfgfile/rte_cfgfile.h<br>
> > +++ b/lib/cfgfile/rte_cfgfile.h<br>
> > @@ -24,7 +24,7 @@ extern "C" {<br>
> > #endif<br>
> ><br>
> > #ifndef CFG_VALUE_LEN<br>
> > -#define CFG_VALUE_LEN 256<br>
> > +#define CFG_VALUE_LEN 2048<br>
> > #endif<br>
> ><br>
> An increase seems ok to me, but is an 8x increase really necessary? If<br>
> lines in the config files are over 1k in size, then it implies that some<br>
> other mechanism would surely be better for configuration.<br>
> Can we make do with an increase to 512 only?<br>
><br>
> /Bruce<br>
<br>
Happy to compromise with 1K.<br>
<br>
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com><br>
<br>
</span></div>
</div>
</body>
</html>