<div dir="ltr"><div dir="ltr"><div class="gmail_default" style="font-family:arial,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 8, 2024 at 11:39 AM Jeremy Spewock <<a href="mailto:jspewock@iol.unh.edu">jspewock@iol.unh.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div style="font-family:arial,sans-serif"><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jan 8, 2024 at 7:01 AM Juraj Linkeš <juraj.linkes@pantheon.tech> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Wed, Jan 3, 2024 at 11:33 PM <<a href="mailto:jspewock@iol.unh.edu" target="_blank">jspewock@iol.unh.edu</a>> wrote:<br>
><br>
> From: Jeremy Spewock <<a href="mailto:jspewock@iol.unh.edu" target="_blank">jspewock@iol.unh.edu</a>><br>
><br>
> Added the options to filter out LLDP and ARP packets when<br>
> sniffing for packets with scapy. This was done using BPF filters to<br>
> ensure that the noise these packets provide does not interfere with test<br>
> cases.<br>
><br>
> Signed-off-by: Jeremy Spewock <<a href="mailto:jspewock@iol.unh.edu" target="_blank">jspewock@iol.unh.edu</a>><br>
> ---<br>
>  dts/framework/test_suite.py                   | 15 +++++++++--<br>
>  dts/framework/testbed_model/tg_node.py        | 14 ++++++++--<br>
>  .../traffic_generator/__init__.py             |  7 ++++-<br>
>  .../capturing_traffic_generator.py            | 22 ++++++++++++++-<br>
>  .../testbed_model/traffic_generator/scapy.py  | 27 +++++++++++++++++++<br>
>  5 files changed, 79 insertions(+), 6 deletions(-)<br>
><br>
<br>
<snip><br>
<br>
> diff --git a/dts/framework/testbed_model/traffic_generator/capturing_traffic_generator.py b/dts/framework/testbed_model/traffic_generator/capturing_traffic_generator.py<br>
> index 0246590333..c1c9facedd 100644<br>
> --- a/dts/framework/testbed_model/traffic_generator/capturing_traffic_generator.py<br>
> +++ b/dts/framework/testbed_model/traffic_generator/capturing_traffic_generator.py<br>
<snip><br>
> @@ -26,6 +27,19 @@ def _get_default_capture_name() -> str:<br>
>      return str(uuid.uuid4())<br>
><br>
><br>
> +@dataclass(slots=True)<br>
<br>
This should also be frozen. If we need a different filter, it's better<br>
to create a new object I think.<br>
<br></blockquote></div></div></blockquote><div><span class="gmail_default" style="font-family:arial,sans-serif">This is also a good point, I'll make this change as well.</span> <br></div></div></div>