<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Hi maintainer of DPDK,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I’ve noticed an error on comment of DPDK version 23.11 rte_cryptodev.h: 928-930<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none">/**</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * Create a symmetric session mempool.</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">@param</span><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> name</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * The unique mempool name.</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">@param</span><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> nb_elts</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * The number of elements in the mempool.</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">@param</span><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> elt_size</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * The size of the element. This value will be ignored if it is smaller than</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * the minimum session header size required for the system. For the user who</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * want to use the same mempool for sym session and session private data it</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * can be the maximum value of all existing devices' private data and session</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * header sizes.</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">@param</span><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> cache_size</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * The number of per-lcore cache elements</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">@param</span><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> priv_size</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * The private data size of each session.</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">@param</span><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> socket_id</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * The *socket_id* argument is the socket identifier in the case of</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * NUMA. The value can be *SOCKET_ID_ANY* if there is no NUMA</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> * constraint for the reserved zone.</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> *
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">@return</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><b><span style="font-size:16.0pt;font-family:Consolas;color:green;mso-ligatures:none"> * - On success return size of the session</span></b><b><span style="font-size:16.0pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></b></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><b><span style="font-size:16.0pt;font-family:Consolas;color:green;mso-ligatures:none"> * - On failure returns 0</span></b><b><span style="font-size:16.0pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></b></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:green;mso-ligatures:none"> */</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">__rte_experimental</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">struct</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"> rte_mempool *<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none">rte_cryptodev_sym_session_pool_create(const char *name,
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">uint32_t</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"> nb_elts,<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"> uint32_t elt_size,
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">uint32_t</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"> cache_size,
</span><span style="font-size:13.5pt;font-family:Consolas;color:blue;mso-ligatures:none">uint16_t</span><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"> priv_size,<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"> int socket_id);<o:p></o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none"><o:p> </o:p></span></p>
<p class="MsoNormal" style="line-height:18.0pt;background:white"><span style="font-size:13.5pt;font-family:Consolas;color:black;mso-ligatures:none">But the return value of this function seems to be a pointer to the mempool created or NULL pointer, instead of
the mempool size.<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Could you please check it? <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thank you and BR,<o:p></o:p></p>
<p class="MsoNormal">Songyi<o:p></o:p></p>
</div>
</body>
</html>