<div dir="ltr">I misinterpreted your comment earlier and prefixed memzone variable name with "gve" instead of memzone name. Will fix it in v4. Thanks!</div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Fri, Jan 19, 2024 at 8:55 PM Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 1/19/2024 2:26 PM, Rushil Gupta wrote: > Read from shared region to retrieve imissed statistics for GQ from device. > > Signed-off-by: Rushil Gupta <<a href="mailto:rushilg@google.com" target="_blank">rushilg@google.com</a>> > Reviewed-by: Joshua Washington <<a href="mailto:joshwash@google.com" target="_blank">joshwash@google.com</a>> > <...> > +static int > +gve_alloc_stats_report(struct gve_priv *priv, > + uint16_t nb_tx_queues, uint16_t nb_rx_queues) > +{ > + char z_name[RTE_MEMZONE_NAMESIZE]; > + int tx_stats_cnt; > + int rx_stats_cnt; > + > + tx_stats_cnt = (GVE_TX_STATS_REPORT_NUM + NIC_TX_STATS_REPORT_NUM) * > + nb_tx_queues; > + rx_stats_cnt = (GVE_RX_STATS_REPORT_NUM + NIC_RX_STATS_REPORT_NUM) * > + nb_rx_queues; > + priv->stats_report_len = sizeof(struct gve_stats_report) + > + sizeof(struct stats) * (tx_stats_cnt + rx_stats_cnt); > + > + snprintf(z_name, sizeof(z_name), "stats_report_%s", priv->pci_dev-><a href="http://device.name" rel="noreferrer" target="_blank">device.name</a>); > + priv->gve_stats_report_mem = rte_memzone_reserve_aligned(z_name, > + priv->stats_report_len, > + rte_socket_id(), > + RTE_MEMZONE_IOVA_CONTIG, PAGE_SIZE); > Adding 'gve_' prefix to memzone name comment seems missed. </blockquote></div>