<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof"><span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">Thank you for the review.<br>
Indeed, shortening the command from "flow actions_update" to "flow update" seems more natural.<br>
However, note that the command updates only the actions of a flow rule and leaves all other parameters unchanged.<br>
My concern is that in the future there can be some "flow pattern_update" command, thus making "flow update" command ambiguous.<br>
Also, the name is consistent with the underlying rte_flow_actions_update() function.<br>
With that in mind, please clarify if the name should still be changed.<br>
</span></div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Dariusz Sosnowski <dsosnowski@nvidia.com><br>
<b>Sent:</b> Monday, February 5, 2024 9:18 PM<br>
<b>To:</b> NBU-Contact-Thomas Monjalon (EXTERNAL) <thomas@monjalon.net>; Mykola Kostenok <mko-plv@napatech.com>; Christian Koue Muf <ckm@napatech.com>; Oleksandr Kolomeiets <okl-plv@napatech.com><br>
<b>Cc:</b> aman.deep.singh@intel.com <aman.deep.singh@intel.com>; yuying.zhang@intel.com <yuying.zhang@intel.com>; dev@dpdk.org <dev@dpdk.org>; Ori Kam <orika@nvidia.com><br>
<b>Subject:</b> RE: [PATCH v2] app/testpmd: support updating flow rule actions</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">> -----Original Message-----<br>
> From: Thomas Monjalon <thomas@monjalon.net><br>
> Sent: Friday, February 2, 2024 10:55<br>
> To: mko-plv@napatech.com; ckm@napatech.com; Oleksandr Kolomeiets<br>
> <okl-plv@napatech.com><br>
> Cc: aman.deep.singh@intel.com; yuying.zhang@intel.com; dev@dpdk.org;<br>
> Ori Kam <orika@nvidia.com>; Dariusz Sosnowski <dsosnowski@nvidia.com><br>
> Subject: Re: [PATCH v2] app/testpmd: support updating flow rule actions<br>
> <br>
> 01/02/2024 10:59, Oleksandr Kolomeiets:<br>
> > "flow actions_update" updates a flow rule specified by a rule ID with<br>
> > a new action list by making a call to "rte_flow_actions_update()":<br>
> ><br>
> > flow actions_update {port_id} {rule_id}<br>
> > actions {action} [/ {action} [...]] / end [user_id]<br>
> ><br>
> > Creating, updating and destroying a flow rule:<br>
> ><br>
> > testpmd> flow create 0 group 1 pattern eth / end actions drop / end<br>
> > Flow rule #0 created<br>
> > testpmd> flow actions_update 0 0 actions queue index 1 / end<br>
> > Flow rule #0 updated with new actions<br>
> > testpmd> flow destroy 0 rule 0<br>
> > Flow rule #0 destroyed<br>
> <br>
> Why not a simple "flow update" command name?<br>
<br>
+1. This would also make it consistent with async version of this command - "flow queue {port_id} update ...".<br>
</div>
</span></font></div>
</body>
</html>