<html>
<head>
<base href="https://bugs.dpdk.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8" class="bz_new_table">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - rt_bitops.h fails to give implied atomicity guarantees"
href="https://bugs.dpdk.org/show_bug.cgi?id=1385">1385</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>rt_bitops.h fails to give implied atomicity guarantees
</td>
</tr>
<tr>
<th>Product</th>
<td>DPDK
</td>
</tr>
<tr>
<th>Version</th>
<td>23.11
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>Normal
</td>
</tr>
<tr>
<th>Component</th>
<td>core
</td>
</tr>
<tr>
<th>Assignee</th>
<td>dev@dpdk.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>mattias.ronnblom@ericsson.com
</td>
</tr>
<tr>
<th>Target Milestone</th>
<td>---
</td>
</tr></table>
<p>
<div class="bz_comment_block">
<pre class="bz_comment_text">The documentation (and the naming) for the rte_bit_relaxed_*() functions in
rte_bitops.h makes clear that all such functions have a relaxed memory order.
The use of the term "relaxed", which most C programmers likely are familiar
with from the C11 memory model specification, itself implies that the
operations are supposed to be atomic. Why otherwise mention the memory
operations are relaxed? Relaxed is the default for non-atomic loads and stores.
In addition, why otherwise declare the address as volatile?
An even stronger indication are the test-and-set family of "relaxed"
rte_bitops.h functions. "Test-and-set" in the low-level C programming context
always implies an atomic operation. A non-atomic test-and-set does not make
sense.
In summary, a perfectly valid interpretation of the API contract is that the
functions are atomic.
However, their implementation is not, which may not be obvious to the causal
API user.
</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://bugs.dpdk.org/show_bug.cgi?id=1385">
<meta itemprop="name" content="View bug">
</div>
<meta itemprop="description" content="Bugzilla bug update notification">
</div>
</body>
</html>