<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<p><snipped></p>
<p><span style="white-space: pre-wrap">
</span></p>
<blockquote type="cite" cite="mid:29fd85f4-d8bf-cd4e-f56c-8fd835e97e0e@huawei.com">
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">- printf("Error: Source or destination numa exceeds the acture numa nodes.\n");
+ printf("Error: %s numa exceeds the available numa nodes.\n",
+ (cfg->src_numa_node >= nr_sockets) ? "Source" : "Destination");
</pre>
</blockquote>
</blockquote>
<p>Thank you for comments, please find my reasoning as `change is
added to address spelling issue of acture numa to available numa`<br>
</p>
<blockquote type="cite" cite="mid:29fd85f4-d8bf-cd4e-f56c-8fd835e97e0e@huawei.com">
<pre class="moz-quote-pre" wrap="">
There are three cases to invoking:
1) src_numa_node >= nr_sockets
2) dst_numa_node >= nr_sockets
3) both src_numa_node and dst_numa_node >= nr_sockets</pre>
</blockquote>
<p>As per my testing, following scenarios are explored <br>
</p>
<p>1) if src-numa is incorrect, we get error message as `source is
incorrect numa`<br>
</p>
<p>2) if dst-numa is incorrect, we get error message as `destination
is incorrect numa`</p>
<p>3) if both src-numa and dst-numa are incorrect, we get error as
`source is incorrect numa`, fixing source and rerunning
`destination is incorrect numa` (which is expected)<br>
</p>
<blockquote type="cite" cite="mid:29fd85f4-d8bf-cd4e-f56c-8fd835e97e0e@huawei.com">
<pre class="moz-quote-pre" wrap="">
It could cover cases 1&2 in your commit, but could not cover case 3.
</pre>
</blockquote>
I am happy to make changes to reflect the third scenario also. But
please note as shared, the real intention is to fix ` acture numa`
to something meaningful.<br>
<blockquote type="cite" cite="mid:29fd85f4-d8bf-cd4e-f56c-8fd835e97e0e@huawei.com">
<pre class="moz-quote-pre" wrap="">
So I think we should keep original implement.</pre>
</blockquote>
<p>I humbly disagree, based on the explanation as shared above. I
can share v2 patch to address <br>
</p>
<p>1. acture numa</p>
<p>2. soruce or destination or src & destination<br>
</p>
<br>
<p><snipped><span style="white-space: pre-wrap">
</span></p>
</body>
</html>