<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=windows-1255"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <div> <div dir="auto">Thanks Ferruh, we will fix and upload a new patchset</div> <div class="x_gmail_extra"><br> <div class="x_gmail_quote">בתאריך 8 במרץ 2024 13:18,‏ Ferruh Yigit <ferruh.yigit@amd.com> כתב:<br type="attribution"> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.<br> <br> <br> <br> On 3/6/2024 12:24 PM, shaibran@amazon.com wrote:<br> > From: Shai Brandes <shaibran@amazon.com><br> ><br> > This patch makes several changes to improve<br> > the style and readability of the code.<br> ><br> > Signed-off-by: Shai Brandes <shaibran@amazon.com><br> > Reviewed-by: Amit Bernstein <amitbern@amazon.com><br> > ---<br> > drivers/net/ena/hal/ena_com.c | 13 +++++--------<br> > 1 file changed, 5 insertions(+), 8 deletions(-)<br> ><br> > diff --git a/drivers/net/ena/hal/ena_com.c b/drivers/net/ena/hal/ena_com.c<br> > index b98540ba63..2db21e7895 100644<br> > --- a/drivers/net/ena/hal/ena_com.c<br> > +++ b/drivers/net/ena/hal/ena_com.c<br> > @@ -1914,15 +1914,14 @@ int ena_com_phc_get_timestamp(struct ena_com_dev *ena_dev, u64 *timestamp)<br> ><br> > /* PHC is in active state, update statistics according to req_id and error_flags */<br> > if ((READ_ONCE16(read_resp->req_id) != phc->req_id) ||<br> > - (read_resp->error_flags & ENA_PHC_ERROR_FLAGS)) {<br> > + (read_resp->error_flags & ENA_PHC_ERROR_FLAGS))<br> > /* Device didn't update req_id during blocking time or timestamp is invalid,<br> > * this indicates on a device error<br> > */<br> > phc->stats.phc_err++;<br> > - } else {<br> > + else<br> > /* Device updated req_id during blocking time with valid timestamp */<br> > phc->stats.phc_exp++;<br> > - }<br> > }<br> ><br> > /* Setting relative timeouts */<br> > @@ -2431,7 +2430,7 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *ena_dev, void *data)<br> > timestamp = (u64)aenq_common->timestamp_low |<br> > ((u64)aenq_common->timestamp_high << 32);<br> ><br> > - ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%" ENA_PRIU64 "s]\n",<br> > + ena_trc_dbg(ena_dev, "AENQ! Group[%x] Syndrome[%x] timestamp: [%" ENA_PRIu64 "s]\n",<br> ><br> <br> 'ENA_PRIu64' is not defined yet in this patch, so patch by patch build<br> fails.<br> <br> </div> </span></font> </body> </html>