<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="#0563C1" vlink="#954F72" style="word-wrap:break-word"> <div class="WordSection1"> Hi Ganapati,<o:p></o:p> <o:p> </o:p> Is it not possible to use rte_event_crypto_adapter_enqueue<o:p></o:p> if you want to send the event context to cryptodev?<o:p></o:p> While using rte_cryptodev_enqueue() all previous stage event context is meant to be lost and <o:p></o:p> It would send a new crypto request to cryptodev and is not supposed to be aware of event context.<o:p></o:p> <o:p> </o:p> P.S. Please fix your mail client to reply in plain text on mailing list.<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> Akhil<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Kundapura, Ganapati <ganapati.kundapura@intel.com> Sent: Tuesday, March 12, 2024 1:22 PM To: Kundapura, Ganapati <ganapati.kundapura@intel.com>; Akhil Goyal <gakhil@marvell.com>; dpdk-dev <dev@dpdk.org>; fanzhang.oss@gmail.com; Ji, Kai <kai.ji@intel.com>; Power, Ciara <ciara.power@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Jerin Jacob <jerinjacobk@gmail.com> Subject: [EXTERNAL] RE: RFC: Using and renaming 8-bit reserved field of rte_crypto_op for implementation specific<o:p></o:p> </div> </div> <o:p> </o:p> Prioritize security for external emails: Confirm sender and content safety before clicking links or opening attachments <o:p></o:p> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="100%" align="center"> </div> Hi DPDK,<o:p></o:p> Any comments on this proposal?<o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Ganapati<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Kundapura, Ganapati <<a href="mailto:ganapati.kundapura@intel.com">ganapati.kundapura@intel.com</a>> Sent: Wednesday, March 6, 2024 10:27 AM To: Akhil Goyal <<a href="mailto:gakhil@marvell.com">gakhil@marvell.com</a>>; dpdk-dev <<a href="mailto:dev@dpdk.org">dev@dpdk.org</a>>; <a href="mailto:fanzhang.oss@gmail.com">fanzhang.oss@gmail.com</a>; Ji, Kai <<a href="mailto:kai.ji@intel.com">kai.ji@intel.com</a>>; Power, Ciara <<a href="mailto:ciara.power@intel.com">ciara.power@intel.com</a>>; Kusztal, ArkadiuszX <<a href="mailto:arkadiuszx.kusztal@intel.com">arkadiuszx.kusztal@intel.com</a>>; Gujjar, Abhinandan S <<a href="mailto:abhinandan.gujjar@intel.com">abhinandan.gujjar@intel.com</a>>; Jayatheerthan, Jay <<a href="mailto:jay.jayatheerthan@intel.com">jay.jayatheerthan@intel.com</a>>; Jerin Jacob <<a href="mailto:jerinjacobk@gmail.com">jerinjacobk@gmail.com</a>> Subject: RE: RFC: Using and renaming 8-bit reserved field of rte_crypto_op for implementation specific<o:p></o:p> </div> </div> <o:p> </o:p> Hi Akhil,<o:p></o:p> No changes in sequence of API’s by adding ‘uint8_t impl_opaque’ to ‘struct rte_crypto_op’.<o:p></o:p> It’s required in case application/event dispatcher passes some implementation specific value in rte_event::impl_opaque, to restore the value <o:p></o:p> back on to rte_event::impl_opaque after enqueue to and dequeue from cryptodev.<o:p></o:p> <o:p> </o:p> Here is the pseudocode for one of the use case<o:p></o:p> Application/event dispatcher passes implementation specific value in rte_event::impl_opaque.<o:p></o:p> struct rte_event ev;<o:p></o:p> rte_event_dequeue_burst(…, &ev, …)<o:p></o:p> struct rte_crypto_op *crypto_op = ev.event_ptr; // ev.impl_opaque some implementation specific value<o:p></o:p> rte_cryptodev_enqueue_burst(…, crypto_op, …) ; // ev.impl_opaque is not passed to crypto_op<o:p></o:p> <o:p> </o:p> With rte_crypto_op::impl_opaque field which is unchanged in library/driver<o:p></o:p> crypto_op->impl_opaque = ev.impl_opaque;<o:p></o:p> rte_cryptodev_enqueue_burst(…, crypto_op, …) ; <o:p></o:p> <o:p> </o:p> …<o:p></o:p> rte_crypto_dequeue_burst(…, crypto_op, …)<o:p></o:p> ev.event_ptr = crypto_op; <o:p></o:p> …<o:p></o:p> rte_event_enqueue_burst(…, &ev, …); // ev::impl_opaque value is lost<o:p></o:p> <o:p> </o:p> with rte_crypto_op::impl_opaque field<o:p></o:p> ev.event_ptr = crypto_op;<o:p></o:p> ev.impl_opaque = crypto_op->impl_opaque; // implementation specific value in rte_event::impl_opaque restored back<o:p></o:p> rte_event_enqueue_burst(…, &ev, …); <o:p></o:p> <o:p> </o:p> Thanks,<o:p></o:p> Ganapati<o:p></o:p> <o:p> </o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Akhil Goyal <<a href="mailto:gakhil@marvell.com">gakhil@marvell.com</a>> Sent: Tuesday, March 5, 2024 10:18 PM To: Kundapura, Ganapati <<a href="mailto:ganapati.kundapura@intel.com">ganapati.kundapura@intel.com</a>>; dpdk-dev <<a href="mailto:dev@dpdk.org">dev@dpdk.org</a>>; <a href="mailto:fanzhang.oss@gmail.com">fanzhang.oss@gmail.com</a>; Ji, Kai <<a href="mailto:kai.ji@intel.com">kai.ji@intel.com</a>>; Power, Ciara <<a href="mailto:ciara.power@intel.com">ciara.power@intel.com</a>>; Kusztal, ArkadiuszX <<a href="mailto:arkadiuszx.kusztal@intel.com">arkadiuszx.kusztal@intel.com</a>>; Gujjar, Abhinandan S <<a href="mailto:abhinandan.gujjar@intel.com">abhinandan.gujjar@intel.com</a>>; Jayatheerthan, Jay <<a href="mailto:jay.jayatheerthan@intel.com">jay.jayatheerthan@intel.com</a>>; Jerin Jacob <<a href="mailto:jerinjacobk@gmail.com">jerinjacobk@gmail.com</a>> Subject: RE: RFC: Using and renaming 8-bit reserved field of rte_crypto_op for implementation specific<o:p></o:p> </div> </div> <o:p> </o:p> Hi Ganapati,<o:p></o:p> <o:p> </o:p> Can you please explain the flow with a sequence of APIs to be used.<o:p></o:p> <o:p> </o:p> Regards,<o:p></o:p> Akhil<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Kundapura, Ganapati <<a href="mailto:ganapati.kundapura@intel.com">ganapati.kundapura@intel.com</a>> Sent: Tuesday, March 5, 2024 12:44 PM To: dpdk-dev <<a href="mailto:dev@dpdk.org">dev@dpdk.org</a>>; Akhil Goyal <<a href="mailto:gakhil@marvell.com">gakhil@marvell.com</a>>; <a href="mailto:fanzhang.oss@gmail.com">fanzhang.oss@gmail.com</a>; Ji, Kai <<a href="mailto:kai.ji@intel.com">kai.ji@intel.com</a>>; Power, Ciara <<a href="mailto:ciara.power@intel.com">ciara.power@intel.com</a>>; Kusztal, ArkadiuszX <<a href="mailto:arkadiuszx.kusztal@intel.com">arkadiuszx.kusztal@intel.com</a>>; Gujjar, Abhinandan S <<a href="mailto:abhinandan.gujjar@intel.com">abhinandan.gujjar@intel.com</a>>; Jayatheerthan, Jay <<a href="mailto:jay.jayatheerthan@intel.com">jay.jayatheerthan@intel.com</a>>; Jerin Jacob <<a href="mailto:jerinjacobk@gmail.com">jerinjacobk@gmail.com</a>> Subject: [EXTERNAL] RFC: Using and renaming 8-bit reserved field of rte_crypto_op for implementation specific<o:p></o:p> </div> </div> <o:p> </o:p> Prioritize security for external emails: Confirm sender and content safety before clicking links or opening attachments <o:p></o:p> <div class="MsoNormal" align="center" style="text-align:center"> <hr size="2" width="100%" align="center"> </div> Hi dpdk-dev,<o:p></o:p> Can 'uint8_t reserved[1]' of 'struct rte_crypto_op' be renamed <o:p></o:p> to 'uint8_t impl_opaque' for implementation specific?<o:p></o:p> <o:p> </o:p> An implementation may use this field to hold implementation specific<o:p></o:p> value to share value between dequeue and enqueue operation and crypto library/driver<o:p></o:p> can also use this field to share implementation specfic value to event crypto adapter/application.<o:p></o:p> <o:p> </o:p> 'struct rte_event' has 'uint8_t impl_opaque' member<o:p></o:p> struct rte_event {<o:p></o:p> ...<o:p></o:p> uint8_t impl_opaque;<o:p></o:p> /**< Implementation specific opaque value.<o:p></o:p> * An implementation may use this field to hold<o:p></o:p> * implementation specific value to share between<o:p></o:p> * dequeue and enqueue operation.<o:p></o:p> * The application should not modify this field.<o:p></o:p> */<o:p></o:p> ...<o:p></o:p> };<o:p></o:p> <o:p> </o:p> Event crypto adapter, on dequeuing the event, enqueues rte_event::event_ptr<o:p></o:p> to cryptodev as rte_crypto_op and converts the dequeued crypto op to rte_event<o:p></o:p> without restoring the implementation specific opaque value.<o:p></o:p> <o:p> </o:p> By having the 'uint8_t impl_opaque' member in 'struct rte_crypto_op' as<o:p></o:p> diff --git a/lib/cryptodev/rte_crypto.h b/lib/cryptodev/rte_crypto.h<o:p></o:p> index dbc2700..af46ec9 100644<o:p></o:p> --- a/lib/cryptodev/rte_crypto.h<o:p></o:p> +++ b/lib/cryptodev/rte_crypto.h<o:p></o:p> @@ -146,10 +146,13 @@ struct rte_crypto_op {<o:p></o:p> /**< TLS record */<o:p></o:p> } param1;<o:p></o:p> /**< Additional per operation parameter 1. */<o:p></o:p> - uint8_t reserved[1];<o:p></o:p> - /**< Reserved bytes to fill 64 bits for<o:p></o:p> - * future additions<o:p></o:p> + uint8_t impl_opaque;<o:p></o:p> + /**< Implementation specific opaque value.<o:p></o:p> + * An implementation may use this field to hold<o:p></o:p> + * implementation specific value to share between<o:p></o:p> + * dequeue and enqueue operation.<o:p></o:p> */<o:p></o:p> +<o:p></o:p> <o:p> </o:p> which is untouched in library/driver and rte_event::impl_opaque field can be restored <o:p></o:p> while enqueuing the event back to eventdev.<o:p></o:p> <o:p> </o:p> Also crypto library/driver can use rte_crypto_op::impl_opaque field to<o:p></o:p> share implementation specific opaque value to the event crypto adapter/application.<o:p></o:p> <o:p> </o:p> I look forward to feedback on this proposal. Patch will be submitted <o:p></o:p> for review once the initial feedback is received.<o:p></o:p> <o:p> </o:p> Thank you,<o:p></o:p> Ganapati<o:p></o:p> </div> </div> </div> </div> </div> </body> </html>