<html>
<head>
<base href="https://bugs.dpdk.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8" class="bz_new_table">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - ice: no way to disable lsc-interrupts"
href="https://bugs.dpdk.org/show_bug.cgi?id=1418">1418</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>ice: no way to disable lsc-interrupts
</td>
</tr>
<tr>
<th>Product</th>
<td>DPDK
</td>
</tr>
<tr>
<th>Version</th>
<td>24.03
</td>
</tr>
<tr>
<th>Hardware</th>
<td>x86
</td>
</tr>
<tr>
<th>OS</th>
<td>Linux
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>Normal
</td>
</tr>
<tr>
<th>Component</th>
<td>other
</td>
</tr>
<tr>
<th>Assignee</th>
<td>dev@dpdk.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>robin@jarry.cc
</td>
</tr>
<tr>
<th>CC</th>
<td>ktraynor@redhat.com
</td>
</tr>
<tr>
<th>Target Milestone</th>
<td>---
</td>
</tr></table>
<p>
<div class="bz_comment_block">
<pre class="bz_comment_text">Hi all,
Apparently, the ice driver does not allow disabling lsc interrupts. Starting
testpmd with --no-lsc-interrupt gives this in the console:
testpmd> ice_interrupt_handler(): OICR: link state change event
Port 0: link state change event
ice_interrupt_handler(): OICR: link state change event
Port 1: link state change event
I tested with version 22.11 which seems not to have the issue. I found a
suspicious commit introduced in 24.03 which may be the culprit:
commit 4e5dc111464e83e9a55fa466d8f682f0027b721e
Author: Qi Zhang <<a href="mailto:qi.z.zhang@intel.com">qi.z.zhang@intel.com</a>>
Date: Thu Dec 14 03:40:54 2023 -0500
net/ice: fix link update
The ice_aq_get_link_info function is not thread-safe. However,
it is possible to simultaneous invocations during both the dev_start
and the LSC interrupt handler, potentially leading to unexpected adminq
errors. This patch addresses the issue by introducing a thread-safe
wrapper that utilizes a spinlock.
Fixes: cf911d90e366 ("net/ice: support link update")
Cc: <a href="mailto:stable@dpdk.org">stable@dpdk.org</a>
Signed-off-by: Qi Zhang <<a href="mailto:qi.z.zhang@intel.com">qi.z.zhang@intel.com</a>>
Acked-by: Qiming Yang <<a href="mailto:qiming.yang@intel.com">qiming.yang@intel.com</a>>
<a href="https://git.dpdk.org/dpdk/commit/?id=4e5dc111464e83e9a55fa466d8f682f0027b721e">https://git.dpdk.org/dpdk/commit/?id=4e5dc111464e83e9a55fa466d8f682f0027b721e</a>
</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://bugs.dpdk.org/show_bug.cgi?id=1418">
<meta itemprop="name" content="View bug">
</div>
<meta itemprop="description" content="Bugzilla bug update notification">
</div>
</body>
</html>