<div dir="ltr">Thanks for the comments. This is due to the tab size, and I will fix them.</div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Apr 24, 2024 at 12:24 AM Stephen Hemminger <<a href="mailto:stephen@networkplumber.org">stephen@networkplumber.org</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Mon, 15 Apr 2024 11:26:02 +0000 Abdullah Ömer Yamaç <<a href="mailto:aomeryamac@gmail.com" target="_blank">aomeryamac@gmail.com</a>> wrote: > + ret = rte_rcu_qsbr_dq_reclaim(h->dq, h->hash_rcu_cfg->max_reclaim_size, > + freed, pending, available); Indention here is odd. I would expect "freed," to line up right under h->dq. Since rte_rcu_qsbrs_dq_reclaim logs error on invalid parameters, this function should as well. Total indent fixes: diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c index 4a44aadd9a..e1ea810024 100644 --- a/lib/hash/rte_cuckoo_hash.c +++ b/lib/hash/rte_cuckoo_hash.c @@ -1590,21 +1590,20 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg) int rte_hash_rcu_qsbr_dq_reclaim(struct rte_hash *h, unsigned int *freed, - unsigned int *pending, unsigned int *available) + unsigned int *pending, unsigned int *available) { int ret; if (h == NULL || h->hash_rcu_cfg == NULL) { + HASH_LOG(ERR, "Invalid input parameter"); rte_errno = EINVAL; return 1; } ret = rte_rcu_qsbr_dq_reclaim(h->dq, h->hash_rcu_cfg->max_reclaim_size, - freed, pending, available); + freed, pending, available); if (ret != 0) { - HASH_LOG(ERR, - "%s: could not reclaim the defer queue in hash table", - __func__); + HASH_LOG(ERR, "%s: could not reclaim the defer queue in hash table", __func__); return 1; } </blockquote></div>