<div dir="ltr"><div>Hi, all</div><div><br></div><div>Should bond slave need set same mac address?</div><div>Like this patch does: <a href="https://github.com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e76833722">https://github.com/batmancn/dpdk/commit/a484ac3f407a6a22d4eb63da23e98e8e76833722</a></div><div>```</div><div>commit a484ac3f407a6a22d4eb63da23e98e8e76833722 (HEAD -> bugfix-bond-same-mac-20240429, batmancn/bugfix-bond-same-mac-20240429)<br>Author: batmancn <<a href="mailto:batmanustc@gmail.com">batmanustc@gmail.com</a>><br>Date:   Mon Apr 29 18:44:18 2024 +0800<br><br>    Bugfix, config same mac address of bond slave.<br>    <br>    Signed-off-by: Simon Jones <<a href="mailto:batmanustc@gmail.com">batmanustc@gmail.com</a>><br><br>diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c<br>index c40d18d128..0387a9b2aa 100644<br>--- a/drivers/net/bonding/rte_eth_bond_pmd.c<br>+++ b/drivers/net/bonding/rte_eth_bond_pmd.c<br>@@ -1562,6 +1562,15 @@ mac_address_members_update(struct rte_eth_dev *bonding_eth_dev)<br>                }<br>                break;<br>        case BONDING_MODE_8023AD:<br>+               for (i = 0; i < internals->slave_count; i++) {<br>+                       if (rte_eth_dev_default_mac_addr_set(<br>+                                       internals->slaves[i].port_id,<br>+                                       bonded_eth_dev->data->mac_addrs)) {<br>+                               RTE_BOND_LOG(ERR, "Failed to update port Id %d MAC address",<br>+                                               internals->slaves[i].port_id);<br>+                               return -1;<br>+                       }<br>+               }<br>                bond_mode_8023ad_mac_address_update(bonding_eth_dev);<br>                break;<br>        case BONDING_MODE_ACTIVE_BACKUP:<br>diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c<br>index f1c658f49e..c3f8b8d01e 100644<br>--- a/lib/ethdev/rte_ethdev.c<br>+++ b/lib/ethdev/rte_ethdev.c<br>@@ -1746,7 +1746,8 @@ rte_eth_dev_start(uint16_t port_id)<br>                return ret;<br> <br>        /* Lets restore MAC now if device does not support live change */<br>-       if (*dev_info.dev_flags & RTE_ETH_DEV_NOLIVE_MAC_ADDR)<br>+       if ((*dev_info.dev_flags & RTE_ETH_DEV_NOLIVE_MAC_ADDR) &&<br>+               !(*dev_info.dev_flags & RTE_ETH_DEV_BONDED_SLAVE))<br>                eth_dev_mac_restore(dev, &dev_info);<br> <br>        diag = (*dev->dev_ops->dev_start)(dev);<br>~<br></div><div>```</div><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>----</div>Simon Jones</div></div></div></div></div></div>