<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:DengXian;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
@font-face
{font-family:"\@DengXian";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Aptos",sans-serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Aptos",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="en-CN" link="#467886" vlink="#96607D" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">+ Arm team to the loop.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Removed invalid email address.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-bottom:12.0pt"><b><span style="font-size:12.0pt;color:black">From:
</span></b><span style="font-size:12.0pt;color:black">Daniel Gregory <daniel.gregory@bytedance.com><br>
<b>Date: </b>Saturday, May 4, 2024 at 2:27</span><span style="font-size:12.0pt;font-family:"Arial",sans-serif;color:black"> </span><span style="font-size:12.0pt;color:black">AM<br>
<b>To: </b>Ruifeng Wang <Ruifeng.Wang@arm.com><br>
<b>Cc: </b>dev@dpdk.org <dev@dpdk.org>, Punit Agrawal <punit.agrawal@bytedance.com>, Liang Ma <liangma@bytedance.com>, Daniel Gregory <daniel.gregory@bytedance.com>, Feifei Wang <Feifei.Wang2@arm.com><br>
<b>Subject: </b>[PATCH v2] eal/arm: replace RTE_BUILD_BUG on non-constant<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span style="font-size:11.0pt">The ARM implementation of rte_pause uses RTE_BUILD_BUG_ON to check<br>
memorder, which is not constant. This causes compile errors when it is<br>
enabled with RTE_ARM_USE_WFE. eg.<br>
<br>
../lib/eal/arm/include/rte_pause_64.h: In function ‘rte_wait_until_equal_16’:<br>
../lib/eal/include/rte_common.h:530:56: error: expression in static assertion is not constant<br>
530 | #define RTE_BUILD_BUG_ON(condition) do { static_assert(!(condition), #condition); } while (0)<br>
| ^~~~~~~~~~~~<br>
../lib/eal/arm/include/rte_pause_64.h:156:9: note: in expansion of macro ‘RTE_BUILD_BUG_ON’<br>
156 | RTE_BUILD_BUG_ON(memorder != rte_memory_order_acquire &&<br>
| ^~~~~~~~~~~~~~~~<br>
<br>
Fix the compile errors by replacing the check with an assert, like in<br>
the generic implementation (lib/eal/include/generic/rte_pause.h).<br>
<br>
Fixes: 875f350924b8 ("eal: add a new helper for wait until scheme")<br>
<br>
Signed-off-by: Daniel Gregory <daniel.gregory@bytedance.com><br>
---<br>
Cc: feifei.wang2@arm.com<br>
---<br>
lib/eal/arm/include/rte_pause_64.h | 8 +++++---<br>
1 file changed, 5 insertions(+), 3 deletions(-)<br>
<br>
<br>
<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>