<div dir="ltr">Hello, I saw two comments, and the first one " Please add: <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a> to the Cc list" then I added <a href="mailto:stable@dpdk.org">stable@dpdk.org</a> to Cc. Would you like me to add it to the commit? Second one : “Set the maximum reclamation size to user provided value” I set this comment to the header. I thought it was more meaningful in the header. If you want also, I can insert it in the description part. Do I miss something else? </div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, May 13, 2024 at 5:34 PM Honnappa Nagarahalli <<a href="mailto:Honnappa.Nagarahalli@arm.com">Honnappa.Nagarahalli@arm.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Abdullah, I do not see the changes I suggested in this version. > On May 13, 2024, at 5:00 AM, Abdullah Ömer Yamaç <<a href="mailto:aomeryamac@gmail.com" target="_blank">aomeryamac@gmail.com</a>> wrote: > > In the previous implementation, the maximum reclamation size was set > to RTE_HASH_RCU_DQ_RECLAIM_MAX and it was not configurable. This patch > uses the configuration argument to set the maximum reclamation size. > > Fixes: 769b2de7fb52 ("hash: implement RCU resources reclamation") > Cc: <a href="mailto:dharmik.thakkar@arm.com" target="_blank">dharmik.thakkar@arm.com</a> > Cc: Honnappa Nagarahalli <<a href="mailto:honnappa.nagarahalli@arm.com" target="_blank">honnappa.nagarahalli@arm.com</a>> > Cc: Yipeng Wang <<a href="mailto:yipeng1.wang@intel.com" target="_blank">yipeng1.wang@intel.com</a>> > Cc: Sameh Gobriel <<a href="mailto:sameh.gobriel@intel.com" target="_blank">sameh.gobriel@intel.com</a>> > Cc: Bruce Richardson <<a href="mailto:bruce.richardson@intel.com" target="_blank">bruce.richardson@intel.com</a>> > Cc: Vladimir Medvedkin <<a href="mailto:vladimir.medvedkin@intel.com" target="_blank">vladimir.medvedkin@intel.com</a>> > > Signed-off-by: Abdullah Ömer Yamaç <<a href="mailto:aomeryamac@gmail.com" target="_blank">aomeryamac@gmail.com</a>> > --- > lib/hash/rte_cuckoo_hash.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c > index 9cf94645f6..f7f0fdfd21 100644 > --- a/lib/hash/rte_cuckoo_hash.c > +++ b/lib/hash/rte_cuckoo_hash.c > @@ -1557,6 +1557,7 @@ rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg) > if (params.size == 0) > params.size = total_entries; > params.trigger_reclaim_limit = cfg->trigger_reclaim_limit; > + params.max_reclaim_size = cfg->max_reclaim_size; > if (params.max_reclaim_size == 0) > params.max_reclaim_size = RTE_HASH_RCU_DQ_RECLAIM_MAX; > params.esize = sizeof(struct __rte_hash_rcu_dq_entry); > -- > 2.34.1 > </blockquote></div>