<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Hello,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
What is the status of that patch ?</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Regards,</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Gregory</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Gregory Etelson <getelson@nvidia.com><br>
<b>Sent:</b> Friday, May 3, 2024 07:27<br>
<b>To:</b> Gregory Etelson <getelson@nvidia.com><br>
<b>Cc:</b> Ali Alnubani <alialnu@nvidia.com>; dev@dpdk.org <dev@dpdk.org>; Maayan Kashani <mkashani@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; bruce.richardson@intel.com <bruce.richardson@intel.com>; stephen@networkplumber.org <stephen@networkplumber.org>;
mb@smartsharesystems.com <mb@smartsharesystems.com><br>
<b>Subject:</b> [PATCH v3] cmdline: increase input buffer size</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">DPDK defines cmdline input buffer size to 512 characters.<br>
That buffer size can be too small for long application input.<br>
For example, the following flow template API testpmd command is 444<br>
bytes long:<br>
```<br>
flow queue 0 create 0 template_table 1000 \<br>
pattern_template 0 actions_template 0 postpone no \<br>
pattern eth / ipv4 / udp / end \<br>
actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \<br>
src_type value src_value 0x31 width 32 / \<br>
modify_field op set dst_type ipv4_src src_type value \<br>
src_value 10101010 width 32 / modify_field op add dst_type \<br>
ipv4_ttl dst_level 0 dst_offset 0 src_type value \<br>
src_value ff width 8 / count / jump group 100 / end<br>
```<br>
<br>
The patch increases cmdline input buffer size to the LINE_MAX value,<br>
which typically is 2048 bytes.<br>
<br>
Signed-off-by: Gregory Etelson <getelson@nvidia.com><br>
Acked-by: Bruce Richardson <bruce.richardson@intel.com><br>
Reviewed-by: Morten Brørup <mb@smartsharesystems.com><br>
---<br>
v2: set RDLINE_BUF_SIZE to LINE_MAX<br>
change the patch subject.<br>
v3: fix Windows compilation error.<br>
---<br>
lib/cmdline/cmdline_private.h | 9 ++++++++-<br>
1 file changed, 8 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/lib/cmdline/cmdline_private.h b/lib/cmdline/cmdline_private.h<br>
index b64f363903..f00b025ecb 100644<br>
--- a/lib/cmdline/cmdline_private.h<br>
+++ b/lib/cmdline/cmdline_private.h<br>
@@ -11,13 +11,20 @@<br>
#include <rte_os_shim.h><br>
#ifdef RTE_EXEC_ENV_WINDOWS<br>
#include <rte_windows.h><br>
+#ifndef LINE_MAX<br>
+/**<br>
+ * The LINE_MAX value is derived from POSIX.<br>
+ * Windows environment may not have POSIX definitions.<br>
+ */<br>
+#define LINE_MAX 2048<br>
+#endif<br>
#else<br>
#include <termios.h><br>
#endif<br>
<br>
#include <cmdline.h><br>
<br>
-#define RDLINE_BUF_SIZE 512<br>
+#define RDLINE_BUF_SIZE LINE_MAX<br>
#define RDLINE_PROMPT_SIZE 32<br>
#define RDLINE_VT100_BUF_SIZE 8<br>
#define RDLINE_HISTORY_BUF_SIZE BUFSIZ<br>
-- <br>
2.43.0<br>
<br>
</div>
</span></font></div>
</body>
</html>