<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<p>BR</p>
<p>Rongwei</p>
<p> </p>
</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Thomas Monjalon <thomas@monjalon.net><br>
<b>Sent:</b> Tuesday, June 4, 2024 19:59<br>
<b>To:</b> rongwei liu <rongweil@nvidia.com><br>
<b>Cc:</b> dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Ferruh Yigit <ferruh.yigit@amd.com>;
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru><br>
<b>Subject:</b> Re: [PATCH v2 2/4] ethdev: add VXLAN last reserved field</span>
<div> </div>
</div>
<div class="elementToProof" style="font-size: 11pt;">External email: Use caution opening links or attachments<br>
<br>
<br>
27/05/2024 04:47, Rongwei Liu:<br>
> Add VXLAN last reserved byte in rte flow packet field.<br>
<br>
You should squash addition in testpmd in the same patch.<br>
Adding a field in rte_flow.h should be atomic with testpmd update.</div>
<div class="elementToProof" style="font-size: 11pt;"><br>
</div>
<div class="elementToProof" style="font-size: 11pt;">Sure. Squash into one commit.<br>
<br>
> @@ -2428,6 +2428,7 @@ enum rte_flow_field_id {<br>
> RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */<br>
> RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. */<br>
> RTE_FLOW_FIELD_RANDOM, /**< Random value. */<br>
> + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN reserved1. */<br>
<br>
It isn't clear what reserved1 is.<br>
You should say it is the last byte of the VXLAN header.</div>
<div class="elementToProof" style="font-size: 11pt;"><br>
</div>
<div class="elementToProof" style="font-size: 11pt;">ACK.</div>
<div class="elementToProof" style="font-size: 11pt;"><br>
<br>
</div>
</body>
</html>