<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<p>BR</p>
<p>Rongwei</p>
<p> </p>
</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Thomas Monjalon <thomas@monjalon.net><br>
<b>Sent:</b> Tuesday, June 4, 2024 23:03<br>
<b>To:</b> rongwei liu <rongweil@nvidia.com><br>
<b>Cc:</b> dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Dariusz Sosnowski <dsosnowski@nvidia.com>; Aman Singh <aman.deep.singh@intel.com>;
Yuying Zhang <yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru><br>
<b>Subject:</b> Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field</span>
<div> </div>
</div>
<div class="elementToProof" style="font-size: 11pt;">External email: Use caution opening links or attachments<br>
<br>
<br>
04/06/2024 14:38, Rongwei Liu:<br>
> --- a/app/test-pmd/cmdline_flow.c<br>
> +++ b/app/test-pmd/cmdline_flow.c<br>
> @@ -1006,6 +1006,7 @@ static const char *const flow_field_ids[] = {<br>
> "ipv6_flow_label", "ipv6_traffic_class",<br>
> "esp_spi", "esp_seq_num", "esp_proto",<br>
> "random",<br>
> + "vxlan_last_rsvd",<br>
> NULL<br>
> };<br>
<br>
How vxlan_last_rsvd is linked to RTE_FLOW_FIELD_VXLAN_RSVD1 in testpmd?<br>
Just because it is the same order?<br>
<br>
Consider the on-the-way VxLAN extension changes, the last reserved byte was naming as "uint8_t rsvd1".<br>
<br>
> --- a/lib/ethdev/rte_flow.h<br>
> +++ b/lib/ethdev/rte_flow.h<br>
> @@ -2428,6 +2428,7 @@ enum rte_flow_field_id {<br>
> RTE_FLOW_FIELD_ESP_SEQ_NUM, /**< ESP Sequence Number. */<br>
> RTE_FLOW_FIELD_ESP_PROTO, /**< ESP next protocol value. */<br>
> RTE_FLOW_FIELD_RANDOM, /**< Random value. */<br>
> + RTE_FLOW_FIELD_VXLAN_RSVD1, /**< VXLAN last reserved byte. */<br>
> };<br>
<br>
I think we should use the same naming as in testpmd.<br>
What about RTE_FLOW_FIELD_VXLAN_LAST_RSVD?<br>
<br>
</div>
<div class="elementToProof" style="font-size: 11pt;">To be honest, no strong objection per my personal thought. Considering the API "vxlan_hdr" names this field as "uint8_t rsvd1", maybe
<span style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; color: rgb(0, 0, 0);">
RTE_FLOW_FIELD_VXLAN_RSVD1 will be clearer for user as 1 vs 1 mapping?</span></div>
<div class="elementToProof" style="font-size: 11pt;"><br>
<br>
</div>
</body>
</html>