<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<div id="Signature">
<p>BR</p>
<p>Rongwei</p>
<p> </p>
</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Thomas Monjalon <thomas@monjalon.net><br>
<b>Sent:</b> Wednesday, June 5, 2024 17:35<br>
<b>To:</b> rongwei liu <rongweil@nvidia.com><br>
<b>Cc:</b> Dariusz Sosnowski <dsosnowski@nvidia.com>; dev@dpdk.org <dev@dpdk.org>; Matan Azrad <matan@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Ori Kam <orika@nvidia.com>; Suanming Mou <suanmingm@nvidia.com>; Aman Singh <aman.deep.singh@intel.com>;
Yuying Zhang <yuying.zhang@intel.com>; Ferruh Yigit <ferruh.yigit@amd.com>; Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru><br>
<b>Subject:</b> Re: [PATCH v4 2/3] ethdev: add VXLAN last reserved field</span>
<div> </div>
</div>
<div class="elementToProof" style="font-size: 11pt;">External email: Use caution opening links or attachments<br>
<br>
<br>
05/06/2024 10:14, rongwei liu:<br>
> > > > > In this patch, "vxlan_last_rsvd" is used in testpmd, so it matches<br>
> > > > > existing "last_rsvd" field in VXLAN item. If we choose to use<br>
> > > > > "rsvd1",<br>
> > > > > we should probably rename all other instances of "last_rsvd" to<br>
> > > > > match.> ><br>
> > > ><br>
> > > > I prefer "vxlan_last_rsvd" for 2 reasons:<br>
> > > > - it is more meaningful<br>
> > > > - we are adding first, second and third reserved fields to<br>
> > > > match<br>
> > > > the 3 bytes of rsvd0 (patch to come)<br>
> > ><br>
> > > Sound clear and reasonable. I would like to propose the alignment between rte_flow_field_id and rte_vxlan_hdr:<br>
> > > 1.<br>
> > ><br>
> > > RTE_FLOW_FIELD_VXLAN_RSVD1 ---> RTE_FLOW_FIELD_VXLAN_LAST_RSVD<br>
> > ><br>
> > > 2.<br>
> > ><br>
> > > "uint8_t rsvd1" ----> "uint8_t last_rsvd"<br>
> ><br>
> > We don't change rte_vxlan_hdr, because we avoid breaking compatibility.<br>
><br>
> How about to add a new union:<br>
><br>
> union {<br>
> uint8_t rsvd1;<br>
> uint8_t last_rsvd;<br>
> }<br>
> RTE_FLOW_FIELD_VXLAN_LAST_RSVD will perfectly match the rte_vxlan_hdr definition.<br>
<br>
It could be a solution, yes,<br>
but I don't see it in your v5.</div>
<div class="elementToProof" style="font-size: 11pt;"><br>
</div>
<div class="elementToProof" style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Should I add this change in my serial or expect it in the upcoming new VXLAN header definitions? </div>
<div class="elementToProof" style="font-size: 11pt;"><br>
<br>
<br>
<br>
</div>
</body>
</html>