<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=windows-1255"> <meta name="Generator" content="Microsoft Exchange Server"> <style></style> </head> <body> <div> <div dir="auto">Sure, thanks!</div> <div class="x_gmail_extra"><br> <div class="x_gmail_quote">בתאריך 5 ביולי 2024 20:32,‏ Ferruh Yigit <ferruh.yigit@amd.com> כתב:<br type="attribution"> </div> </div> </div> <font size="2"><span style="font-size:10pt;"> <div class="PlainText">CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.<br> <br> <br> <br> On 6/6/2024 2:33 PM, shaibran@amazon.com wrote:<br> > From: Shai Brandes <shaibran@amazon.com><br> ><br> > Replaced `enable_llq`, `normal_llq_hdr` and `large_llq_hdr`<br> > devargs with a new shared devarg named `llq_policy` that<br> > implements the same logic and accepts the following values:<br> > 0 - Disable LLQ.<br> > Use with extreme caution as it leads to a huge performance<br> > degradation on AWS instances from 6th generation onwards.<br> > 1 - Accept device recommended LLQ policy (Default).<br> > Device can recommend normal or large LLQ policy.<br> > 2 - Enforce normal LLQ policy.<br> > 3 - Enforce large LLQ policy.<br> > Required for packets with header that exceed 96 bytes on<br> > AWS instances prior to 5th generation.<br> ><br> > Signed-off-by: Shai Brandes <shaibran@amazon.com><br> > Reviewed-by: Amit Bernstein <amitbern@amazon.com><br> ><br> <br> Hi Shai,<br> <br> This patch changes device parameters and impacts end user.<br> Although this is not part of ABI policy, and we don't have an explicit<br> policy around it, but since it may impact end user experience, would you<br> be OK to postpone this patch to v24.11 release, where ABI break is planned?<br> <br> <br> <br> </div> </span></font> </body> </html>