<html><head><meta http-equiv="content-type" content="text/html; charset=ISO-8859-1"><style>body { line-height: 1.5; }body { font-size: 14px; font-family: "Microsoft YaHei UI"; color: rgb(0, 0, 0); line-height: 1.5; }</style></head><body> <div><span></span><div><span style="background-color: transparent;">></span>> The code to update link status is not safe in secondary process.</div><div><span style="background-color: transparent;">></span>> If called from secondary it will crash, example from dumpcap:</div><div><span style="background-color: transparent;">></span>> eth_em_link_update</div><div><span style="background-color: transparent;">></span>></div><div><span style="background-color: transparent;">></span>> Signed-off-by: Jun Wang <junwang01@cestc.cn></div><div><span style="background-color: transparent;">></span> </div><div><span style="background-color: transparent;">> </span>Wouldn't it be better to fix the code in e1000_check_link to work in</div><div><span style="background-color: transparent;">> </span>secondary process. There are network virtual appliances that use</div><div><span style="background-color: transparent;">> </span>secondary process for all processing.</div></div> <div><br></div><div>Yes, the e1000 virtual network card currently does not work properly </div><div>in the secondary process. After skipping eth_em_link_update, I tested</div><div>the e1000 card and it was able to capture packets normally. For the </div><div>secondary process, I think eth_em_link_update is not necessary.</div><div><br></div><hr style="width: 210px; height: 1px;" color="#b5c4df" size="1" align="left"> <div><span><div style="MARGIN: 10px; FONT-FAMILY: verdana; FONT-SIZE: 10pt">Jun Wang</div></span></div> </body></html>