<div dir="ltr">Thanks Ferruh.</div> <div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 22, 2024 at 7:41 PM Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com">ferruh.yigit@amd.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 7/22/2024 12:10 PM, Tathagat Priyadarshi wrote: > Fixing Typo in updating the TX queue state > > Signed-off-by: Tathagat Priyadarshi <<a href="mailto:tathagat.dpdk@gmail.com" target="_blank">tathagat.dpdk@gmail.com</a>> > Good catch, thanks Tathagat. I think impact is more than just typo, so let me update the patch title as: net/gve: fix Tx queue state on queue start Also needs fixes tag: Fixes: b044845bb015 ("net/gve: support queue start/stop") Cc: <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a> With above changes, Reviewed-by: Ferruh Yigit <<a href="mailto:ferruh.yigit@amd.com" target="_blank">ferruh.yigit@amd.com</a>> Applied to dpdk-next-net/main, thanks. > --- > drivers/net/gve/gve_tx.c | 2 +- > drivers/net/gve/gve_tx_dqo.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/gve/gve_tx.c b/drivers/net/gve/gve_tx.c > index 70d3ef0..500ae31 100644 > --- a/drivers/net/gve/gve_tx.c > +++ b/drivers/net/gve/gve_tx.c > @@ -688,7 +688,7 @@ > > rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr); > > - dev->data->rx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED; > + dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED; > > return 0; > } > diff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c > index a65e6aa..1b85557 100644 > --- a/drivers/net/gve/gve_tx_dqo.c > +++ b/drivers/net/gve/gve_tx_dqo.c > @@ -392,7 +392,7 @@ > > rte_write32(rte_cpu_to_be_32(GVE_IRQ_MASK), txq->ntfy_addr); > > - dev->data->rx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED; > + dev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED; > > return 0; > } </blockquote></div>