<!DOCTYPE html><html><head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> </head> <body> Hi all, This patch breaks ipsec tests with ipsec-secgw: <pre style="outline: none !important; margin: 0px; padding: 9px 12px; max-height: 30em; overflow: auto; white-space: pre; overflow-wrap: normal; word-break: normal; color: rgb(23, 43, 77); font-size: 12px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-indent: 0px; text-transform: none; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(244, 245, 247); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial;">./examples/ipsec-secgw/test/run_test.sh -4 trs_aesctr_sha1 ... ERROR: ./examples/ipsec-secgw/test/linux_test.sh failed for dst=192.168.31.14, sz=1 test IPv4 trs_aesctr_sha1 finished with status 1 ERROR test trs_aesctr_sha1 FAILED</pre> <div class="moz-cite-prefix">On 03/07/2024 18:58, Akhil Goyal wrote: </div> <blockquote type="cite" cite="mid:CO6PR18MB4484AEA4C81715872976351BD8DD2@CO6PR18MB4484.namprd18.prod.outlook.com"> <pre class="moz-quote-pre" wrap=""> </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">-----Original Message----- From: Akhil Goyal <a class="moz-txt-link-rfc2396E" href="mailto:gakhil@marvell.com"><gakhil@marvell.com></a> Sent: Friday, March 15, 2024 12:42 AM To: Akhil Goyal <a class="moz-txt-link-rfc2396E" href="mailto:gakhil@marvell.com"><gakhil@marvell.com></a>; Chaoyong He <a class="moz-txt-link-rfc2396E" href="mailto:chaoyong.he@corigine.com"><chaoyong.he@corigine.com></a>; <a class="moz-txt-link-abbreviated" href="mailto:dev@dpdk.org">dev@dpdk.org</a> Cc: <a class="moz-txt-link-abbreviated" href="mailto:oss-drivers@corigine.com">oss-drivers@corigine.com</a>; Shihong Wang <a class="moz-txt-link-rfc2396E" href="mailto:shihong.wang@corigine.com"><shihong.wang@corigine.com></a>; <a class="moz-txt-link-abbreviated" href="mailto:stable@dpdk.org">stable@dpdk.org</a> Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">Subject: RE: [EXTERNAL] [PATCH v2] examples/ipsec-secgw: fix SA salt endianness problem </pre> <blockquote type="cite"> <pre class="moz-quote-pre" wrap="">From: Shihong Wang <a class="moz-txt-link-rfc2396E" href="mailto:shihong.wang@corigine.com"><shihong.wang@corigine.com></a> The SA salt of struct ipsec_sa is a CPU-endian u32 variable, but it’s value is stored in an array of encryption or authentication keys according to big-endian. So it maybe need to convert the endianness order to ensure that the value assigned to the SA salt is CPU-endian. Fixes: 50d75cae2a2c ("examples/ipsec-secgw: initialize SA salt") Fixes: 9413c3901f31 ("examples/ipsec-secgw: support additional algorithms") Fixes: 501e9c226adf ("examples/ipsec-secgw: add AEAD parameters") Cc: <a class="moz-txt-link-abbreviated" href="mailto:stable@dpdk.org">stable@dpdk.org</a> Signed-off-by: Shihong Wang <a class="moz-txt-link-rfc2396E" href="mailto:shihong.wang@corigine.com"><shihong.wang@corigine.com></a> Reviewed-by: Chaoyong He <a class="moz-txt-link-rfc2396E" href="mailto:chaoyong.he@corigine.com"><chaoyong.he@corigine.com></a> </pre> </blockquote> <pre class="moz-quote-pre" wrap="">Acked-by: Akhil Goyal <a class="moz-txt-link-rfc2396E" href="mailto:gakhil@marvell.com"><gakhil@marvell.com></a> Applied to dpdk-next-crypto </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> The patch is pulled back from dpdk-next-crypto. This change may cause all the PMDs to fail these cases. Would need acks from PMDs. </pre> </blockquote> <pre class="moz-quote-pre" wrap=""> Applied to dpdk-next-crypto No update from PMD owners. Applying it before RC2 so that we have time for fixes if needed. </pre> </blockquote> <pre class="moz-signature" cols="72">-- Regards, Vladimir</pre> </body> </html>