<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> From: Chengwen Feng <fengchengwen@huawei.com></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Sent: Thursday, August 1, 2024 12:11 PM</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> To: thomas@monjalon.net <thomas@monjalon.net>; dev@dpdk.org <dev@dpdk.org></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Cc: Van Haaren, Harry <harry.van.haaren@intel.com>; wangchenxingyu@huawei.com <wangchenxingyu@huawei.com></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Subject: [PATCH] examples/eventdev: fix segment fault with generic pipeline</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> </div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> There was a segmentation fault when executing eventdev_pipeline with</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> command [1] with ConnectX-5 NIC card:</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> 0x000000000079208c in rte_eth_tx_buffer (tx_pkt=0x16f8ed300, buffer=0x100, queue_id=11, port_id=0) at ../lib/ethdev/rte_ethdev.h:6636</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> txa_service_tx (txa=0x17b19d080, ev=0xffffffffe500, n=4) at ../lib/eventdev/rte_event_eth_tx_adapter.c:631</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> 0x0000000000792234 in txa_service_func (args=0x17b19d080) at ../lib/eventdev/rte_event_eth_tx_adapter.c:666</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> 0x00000000008b0784 in service_runner_do_callback (s=0x17fffe100, cs=0x17ffb5f80, service_idx=2) at ../lib/eal/common/rte_service.c:405</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> 0x00000000008b0ad8 in service_run (i=2, cs=0x17ffb5f80, service_mask=18446744073709551615, s=0x17fffe100, serialize_mt_unsafe=0)</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> at ../lib/eal/common/rte_service.c:441</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> 0x00000000008b0c68 in rte_service_run_iter_on_app_lcore (id=2, serialize_mt_unsafe=0) at ../lib/eal/common/rte_service.c:477</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> 0x000000000057bcc4 in schedule_devices (lcore_id=0) at ../examples/eventdev_pipeline/pipeline_common.h:138</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> 0x000000000057ca94 in worker_generic_burst (arg=0x17b131e80) at ../examples/eventdev_pipeline/pipeline_worker_generic.c:83</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> 0x00000000005794a8 in main (argc=11, argv=0xfffffffff470) at ../examples/eventdev_pipeline/main.c:449</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> The root cause is that the queue_id (11) is invalid, the queue_id comes</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> from mbuf.hash.txadapter.txq which may pre-write by NIC driver when</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> receiving packets (e.g. pre-write mbuf.hash.fdir.hi field).</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Good bug report, thanks for the detailed info on hash.fdir.hi union-ed with txadapter fields.</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
I don't have the specific HW to test, so code review only.</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
I don't recall the TXQ quantities etc (been a number of years since I worked on this code...!)</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
so I'll +CC Pavan who reworked the logic around generic workers & eventdev stages, and might recall?</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Because this example only enabled one ethdev queue, so fixes it by reset</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> txq to zero in the first worker stage.</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> [1] dpdk-eventdev_pipeline -l 0-48 --vdev event_sw0 -- -r1 -t1 -e1 -w ff0 -s5 -n0 -c32 -W1000 -D</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> When launch eventdev_pipeline with command [1], event_sw</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Fixes: 81fb40f95c82 ("examples/eventdev: add generic worker pipeline")</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Cc: stable@dpdk.org</div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com></div>
<div style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
> Reported-by: Chenxingyu Wang <wangchenxingyu@huawei.com></div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Generally the change looks fine - I'll wait a few days for Pavan's input, and otherwise review & Ack assuming no issues found.</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<br>
</div>
<div class="elementToProof" style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
Thanks for the patch! -Harry</div>
</body>
</html>