<div class="zcontentRow"><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">>> +struct zxdh_gdma_buff_desc {</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">>> +    uint SrcAddr_L;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint DstAddr_L;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint Xpara;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint ZY_para;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint ZY_SrcStep;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint ZY_DstStep;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint ExtAddr;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint LLI_Addr_L;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint LLI_Addr_H;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint ChCont;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint LLI_User;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint ErrAddr;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint Control;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint SrcAddr_H;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint DstAddr_H;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +    uint Reserved;</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +};</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>> +</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>Why is this driver using uint type?</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>It should be using datatypes with explicit size (like uint32_t) to</span><br style="box-sizing: border-box; outline: 0px; font-family: MicrosoftYaHei; white-space: normal; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);"><span style="font-family: MicrosoftYaHei; background-color: rgb(255, 255, 255);">></span>make sure it can be used on both 32 and 64 bit builds.</span></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;">This was an oversight, I will fix it as suggested. </p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;">Thanks</p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><div class="zhistoryRow" style="display: block;"><div class="zhistoryDes" style="width: 100%; height: 28px; line-height: 28px; background-color: #E0E5E9; color: #1388FF; text-align: center;">Original</div><div id="zwriteHistoryContainer"><div class="control-group zhistoryPanel"><div class="zhistoryHeader" style="padding: 8px; background-color: #F5F6F8;"><div><strong>From: </strong><span class="zreadUserName">StephenHemminger <stephen@networkplumber.org></span></div><div><strong>To: </strong><span class="zreadUserName" style="display: inline;">张勇10313449;</span></div><div><strong>Cc: </strong><span class="zreadUserName" style="display: inline;">dev@dpdk.org <dev@dpdk.org>;</span></div><div><strong>Date: </strong><span class="">2024年08月05日 23:46</span></div><div><strong>Subject: </strong><span class="zreadTitle"><strong>Re: [v1,1/5] raw/zxdh: introduce zxdh raw device driver</strong></span></div></div><div class="zhistoryContent">On Mon,  5 Aug 2024 21:34:53 +0800<br>Yong Zhang <zhang.yong25@zte.com.cn> wrote:<br> <br>> +struct zxdh_gdma_buff_desc {<br>> +    uint SrcAddr_L;<br>> +    uint DstAddr_L;<br>> +    uint Xpara;<br>> +    uint ZY_para;<br>> +    uint ZY_SrcStep;<br>> +    uint ZY_DstStep;<br>> +    uint ExtAddr;<br>> +    uint LLI_Addr_L;<br>> +    uint LLI_Addr_H;<br>> +    uint ChCont;<br>> +    uint LLI_User;<br>> +    uint ErrAddr;<br>> +    uint Control;<br>> +    uint SrcAddr_H;<br>> +    uint DstAddr_H;<br>> +    uint Reserved;<br>> +};<br>> +<br> <br>Why is this driver using uint type?<br>It should be using datatypes with explicit size (like uint32_t) to<br>make sure it can be used on both 32 and 64 bit builds.</div></div></div></div><p><br></p></div>