<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
mso-ligatures:standardcontextual;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:"Calibri",sans-serif;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 129.75pt 1.0in 129.7pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#467886" vlink="#96607D" style="word-wrap:break-word">
<p style="font-family:Calibri;font-size:10pt;color:#0000FF;margin:5pt;font-style:normal;font-weight:normal;text-decoration:none;" align="Left">
[AMD Official Use Only - AMD Internal Distribution Only]<br>
</p>
<br>
<div>
<div class="WordSection1">
<p class="MsoPlainText"><span style="font-size:9.0pt;font-family:"Verdana",sans-serif">Hi Stephen,
<o:p></o:p></span></p>
<p class="MsoPlainText"><o:p> </o:p></p>
<p class="MsoPlainText">> -----Original Message-----</p>
<p class="MsoPlainText">> From: Stephen Hemminger <stephen@networkplumber.org></p>
<p class="MsoPlainText">> Sent: Wednesday, July 24, 2024 8:10 PM</p>
<p class="MsoPlainText">> To: Tummala, Sivaprasad <Sivaprasad.Tummala@amd.com></p>
<p class="MsoPlainText">> Cc: david.hunt@intel.com; anatoly.burakov@intel.com;</p>
<p class="MsoPlainText">> thomas@monjalon.net; Yigit, Ferruh <Ferruh.Yigit@amd.com>;</p>
<p class="MsoPlainText">> david.marchand@redhat.com; dev@dpdk.org</p>
<p class="MsoPlainText">> Subject: Re: [RFC PATCH 1/2] power: fix power library with --lcores</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> Caution: This message originated from an External Source. Use proper caution</p>
<p class="MsoPlainText">> when opening attachments, clicking links, or responding.</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> On Wed, 24 Jul 2024 13:03:35 +0000</p>
<p class="MsoPlainText">> Sivaprasad Tummala <<a href="mailto:sivaprasad.tummala@amd.com"><span style="color:windowtext;text-decoration:none">sivaprasad.tummala@amd.com</span></a>> wrote:</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> > + lcore_cpus = rte_lcore_cpuset(lcore_id);</p>
<p class="MsoPlainText">> > + if (CPU_COUNT(&lcore_cpus) != 1) {</p>
<p class="MsoPlainText">> > + POWER_LOG(ERR, "Power library doesn't support lcore %u mapping</p>
<p class="MsoPlainText">> "</p>
<p class="MsoPlainText">> > + "to %u cpus", lcore_id, CPU_COUNT(&lcore_cpus));</p>
<p class="MsoPlainText">> > + return -1;</p>
<p class="MsoPlainText">> > + }</p>
<p class="MsoPlainText">> > + for (cpu = 0; cpu < CPU_SETSIZE; cpu++) {</p>
<p class="MsoPlainText">> > + if (CPU_ISSET(cpu, &lcore_cpus))</p>
<p class="MsoPlainText">> > + break;</p>
<p class="MsoPlainText">> > + }</p>
<p class="MsoPlainText">> </p>
<p class="MsoPlainText">> You are copy and pasting the same code into multiple places which indicates it</p>
<p class="MsoPlainText">> should be an API function.</p>
<p class="MsoPlainText"><span style="color:black">ACK! Will fix this in next version.
<o:p></o:p></span></p>
</div>
</div>
</body>
</html>