<div dir="ltr">Hi David, Robin,<div><br></div><div>Thanks, I'll send v2 with the fix.</div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">сб, 28 сент. 2024 г. в 00:59, David Marchand <<a href="mailto:david.marchand@redhat.com">david.marchand@redhat.com</a>>:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;border-left-color:rgb(204,204,204);padding-left:1ex">On Fri, Sep 27, 2024 at 6:13 PM Robin Jarry <<a href="mailto:rjarry@redhat.com" target="_blank">rjarry@redhat.com</a>> wrote:<br>
><br>
> Vladimir Medvedkin, Sep 06, 2024 at 13:09:<br>
> > Currently, for DIR24-8 algorithm, the tbl8 group is freed even though the<br>
> > readers might be using the tbl8 group entries. The freed tbl8 group can<br>
> > be reallocated quickly. As a result, lookup may be performed incorrectly.<br>
> ><br>
> > To address that, RCU QSBR is integrated for safe tbl8 group reclamation.<br>
> ><br>
> > Signed-off-by: Vladimir Medvedkin <<a href="mailto:vladimir.medvedkin@intel.com" target="_blank">vladimir.medvedkin@intel.com</a>><br>
> > ---<br>
><br>
> > diff --git a/lib/fib/meson.build b/lib/fib/meson.build<br>
> > index 6795f41a0a..1895f37050 100644<br>
> > --- a/lib/fib/meson.build<br>
> > +++ b/lib/fib/meson.build<br>
> > @@ -11,6 +11,7 @@ endif<br>
> >  sources = files('rte_fib.c', 'rte_fib6.c', 'dir24_8.c', 'trie.c')<br>
> >  headers = files('rte_fib.h', 'rte_fib6.h')<br>
> >  deps += ['rib']<br>
> > +deps += ['rcu']<br>
><br>
> Hi Vladimir,<br>
><br>
> thanks a lot for working on this!<br>
><br>
> I tested with static linking and there is a missing dependency to<br>
> static_rte_rcu:<br>
><br>
> In file included from ../subprojects/dpdk/lib/fib/dir24_8_avx512.c:6:<br>
> ../subprojects/dpdk/lib/fib/rte_fib.h:19:10: fatal error: rte_rcu_qsbr.h: No such file or directory<br>
>    19 | #include <rte_rcu_qsbr.h><br>
>       |          ^~~~~~~~~~~~~~~~<br>
><br>
> After adding it:<br>
><br>
> @@ -45,7 +45,7 @@ if dpdk_conf.has('RTE_ARCH_X86_64') and binutils_ok<br>
>      elif cc.has_multi_arguments('-mavx512f', '-mavx512dq')<br>
>          dir24_8_avx512_tmp = static_library('dir24_8_avx512_tmp',<br>
>                  'dir24_8_avx512.c',<br>
> -                dependencies: static_rte_eal,<br>
> +                dependencies: [static_rte_eal, static_rte_rcu],<br>
>                  c_args: cflags + ['-mavx512f', '-mavx512dq'])<br>
>          objs += dir24_8_avx512_tmp.extract_objects('dir24_8_avx512.c')<br>
>          cflags += ['-DCC_DIR24_8_AVX512_SUPPORT']<br>
><br>
> I get another error:<br>
><br>
> In file included from /usr/lib/gcc/x86_64-redhat-linux/14/include/immintrin.h:65,<br>
>                  from /usr/lib/gcc/x86_64-redhat-linux/14/include/x86intrin.h:32,<br>
>                  from ../subprojects/dpdk/lib/eal/x86/include/rte_vect.h:26,<br>
>                  from ../subprojects/dpdk/lib/fib/dir24_8_avx512.c:5:<br>
> /usr/lib/gcc/x86_64-redhat-linux/14/include/avx512bwintrin.h: In function ‘dir24_8_vec_lookup_x16’:<br>
> /usr/lib/gcc/x86_64-redhat-linux/14/include/avx512bwintrin.h:1947:1: error: inlining failed in call to ‘always_inline’ ‘_mm512_shuffle_epi8’: target specific option mismatch<br>
>  1947 | _mm512_shuffle_epi8 (__m512i __A, __m512i __B)<br>
>       | ^~~~~~~~~~~~~~~~~~~<br>
> ../subprojects/dpdk/lib/fib/dir24_8_avx512.c:38:26: note: called from here<br>
>    38 |                 ip_vec = _mm512_shuffle_epi8(ip_vec, bswap32);<br>
>       |                          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
> /usr/lib/gcc/x86_64-redhat-linux/14/include/avx512bwintrin.h:1947:1: error: inlining failed in call to ‘always_inline’ ‘_mm512_shuffle_epi8’: target specific option mismatch<br>
>  1947 | _mm512_shuffle_epi8 (__m512i __A, __m512i __B)<br>
>       | ^~~~~~~~~~~~~~~~~~~<br>
> ../subprojects/dpdk/lib/fib/dir24_8_avx512.c:38:26: note: called from here<br>
>    38 |                 ip_vec = _mm512_shuffle_epi8(ip_vec, bswap32);<br>
>       |                          ^~~~~~~~~<br>
<br>
The latter issue is because you had applied the endianness change.<br>
I replied in the other thread.<br>
<br>
<br>
-- <br>
David Marchand<br>
<br>
</blockquote></div><br clear="all"><div><br></div><span class="gmail_signature_prefix">-- </span><br><div dir="ltr" class="gmail_signature"><div dir="ltr"><div>Regards,<br></div>Vladimir<br></div></div>