<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div class="elementToProof" style="text-align: left; text-indent: 0px; line-height: 1.1; margin: 20px 0px 10px; font-family: "IntelOne Text"; font-size: 10pt; color: rgb(0, 0, 0);">
I'm not see any issue with original code, can you give more details about crash so I can try to reproduce at my end. </div>
<div class="elementToProof" style="text-align: left; text-indent: 0px; line-height: 1.1; margin: 20px 0px 10px; font-family: "IntelOne Text"; font-size: 10pt; color: rgb(0, 0, 0);">
cc <span style="font-weight: 500;">kirill.rybalchenko@intel.com for review </span></div>
<div id="appendonsend" style="color: inherit;"></div>
<div style="font-family: "IntelOne Text"; font-size: 10pt; color: rgb(0, 0, 0);">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg" dir="ltr" style="color: inherit;"><span style="font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);"><b>From:</b> Yong Liang <1269690261@qq.com><br>
<b>Sent:</b> 18 September 2024 15:15<br>
<b>To:</b> dev@dpdk.org <dev@dpdk.org><br>
<b>Cc:</b> roy.fan.zhang@intel.com <roy.fan.zhang@intel.com><br>
<b>Subject:</b> [PATCH] crypto/scheduler: fix incorrect variable usage</span>
<div> </div>
</div>
<div style="font-size: 11pt;">The variable `pending_deq_ops` was incorrectly used<br>
instead of `pending_enq_ops`.<br>
This causes the program to crash<br>
when the worker PMD accesses the session<br>
<br>
Bugzilla ID: 1537<br>
Fixes: 6812b9bf470e ("crypto/scheduler: use unified session")<br>
Cc: roy.fan.zhang@intel.com<br>
<br>
Signed-off-by: Yong Liang <1269690261@qq.com><br>
---<br>
drivers/crypto/scheduler/scheduler_multicore.c | 4 ++--<br>
1 file changed, 2 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/drivers/crypto/scheduler/scheduler_multicore.c b/drivers/crypto/scheduler/scheduler_multicore.c<br>
index a21b522f9f..70f8a25b70 100644<br>
--- a/drivers/crypto/scheduler/scheduler_multicore.c<br>
+++ b/drivers/crypto/scheduler/scheduler_multicore.c<br>
@@ -191,11 +191,11 @@ mc_scheduler_worker(struct rte_cryptodev *dev)<br>
worker->qp_id,<br>
&enq_ops[pending_enq_ops_idx],<br>
pending_enq_ops);<br>
- if (processed_ops < pending_deq_ops)<br>
+ if (processed_ops < pending_enq_ops)<br>
scheduler_retrieve_sessions(<br>
&enq_ops[pending_enq_ops_idx +<br>
processed_ops],<br>
- pending_deq_ops - processed_ops);<br>
+ pending_enq_ops - processed_ops);<br>
pending_enq_ops -= processed_ops;<br>
pending_enq_ops_idx += processed_ops;<br>
inflight_ops += processed_ops;<br>
--<br>
2.43.0<br>
<br>
</div>
</body>
</html>