<div dir="ltr"><div dir="ltr">Thanks Nick this looks (almost) ready to be applied to next-dts. Other than a little disconnect between your series and Dean's Patch-145500 ("dts: add VLAN methods to testpmd shell") series which I will flag below, I think this looks good.</div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 8, 2024 at 4:45 PM Nicholas Pratte <<a href="mailto:npratte@iol.unh.edu">npratte@iol.unh.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">The mac address filter test suite, whose test cases are based on old<br>
DTS's test cases, has been refactored to interface with the new DTS<br>
framework.<br>
<br>
In porting over this test suite into the new framework, some<br>
adjustments were made, namely in the EAL and TestPMD parameter provided<br>
before executing the application. While the original test plan was<br>
referenced, by and large, only for the individual test cases, I'll leave<br>
the parameters the original test plan was asking for below for the sake<br>
of discussion:<br>
<br>
--burst=1 --rxpt=0 --rxht=0 --rxwt=0 --txpt=36 --txht=0 --txwt=0<br>
--txfreet=32 --rxfreet=64 --mbcache=250 --portmask=0x3<br></blockquote><div><br></div><div>I think including the params was good for discussion, but should be dropped for the final commit message which should be clean, and explain what the commit is adding.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
+ @func_test<br>
+ def test_add_remove_mac_addresses(self) -> None:<br>
+ """Assess basic mac addressing filtering functionalities.<br>
+<br>
+ This test case validates for proper behavior of mac address filtering with both<br>
+ a port's default, burned-in mac address, as well as additional mac addresses<br>
+ added to the PMD. Packets should either be received or not received depending on<br>
+ the properties applied to the PMD at any given time.<br>
+<br>
+ Test:<br>
+ Start TestPMD with promiscuous mode.<br></blockquote><div><br></div><div>Should this be "without?" </div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+ Send a packet with the port's default mac address. (Should receive)<br>
+ Send a packet with fake mac address. (Should not receive)<br>
+ Add fake mac address to the PMD's address pool.<br>
+ Send a packet with the fake mac address to the PMD. (Should receive)<br>
+ Remove the fake mac address from the PMD's address pool.<br>
+ Send a packet with the fake mac address to the PMD. (Should not receive)<br>
+ """<br>
+ with TestPmdShell(self.sut_node) as testpmd:<br>
+ testpmd.set_promisc(0, on=False)<br></blockquote><div><br></div><div>The parameter is no longer named "on," it is named "enable" in Dean's vlan methods series which you listed a dependency on. So unless I'm misunderstanding, there is a disconnect between your series. I changed the param to enable and then the testsuite runs.</div><div><br></div><div>Please make sure you do a test run before you submit a new version, even if the changes seem trivial. :)</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
+ Test:<br>
+ Start TestPMD with promiscuous mode.<br></blockquote><div><br></div><div>same as above</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
+ Add a fake multicast address to the PMD's multicast address pool.<br>
+ Send a packet with the fake multicast address to the PMD. (Should receive)<br>
+ Set vlan filtering on the PMD, and add vlan ID to the PMD.<br>
+ Send a packet with the fake multicast address and vlan ID to the PMD. (Should receive)<br>
+ Send a packet with the fake multicast address and a different vlan ID to the PMD.<br>
+ (Should not receive)<br>
+ Remove the vlan tag from the PMD, and turn vlan filtering off on the PMD.<br>
+ Send a packet with the fake multicast address and no vlan tag to the PMD.<br>
+ (Should receive)<br>
+ Remove the fake multicast address from the PMDs multicast address filter.<br>
+ Send a packet with the fake multicast address to the PMD. (Should not receive)<br>
+ """<br>
+ with TestPmdShell(self.sut_node) as testpmd:<br>
+ testpmd.start()<br>
+ testpmd.set_promisc(0, on=False)<br></blockquote><div><br></div><div>same as above.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br>
-- <br>
2.44.0<br>
<br></blockquote><div><br></div><div>Thanks looks good overall.</div><div><br></div><div>Reviewed-by: Patrick Robb <<a href="mailto:probb@iol.unh.edu">probb@iol.unh.edu</a>> </div></div></div>