<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"> <head> <meta http-equiv="Content-Type" content="text/html; charset=utf-8"> <meta name="Generator" content="Microsoft Word 15 (filtered medium)"> <style></style> </head> <body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word"> <div class="WordSection1"> From discussion with Thomas in previous versions of this patch, we agreed to omit both markers. > From: Thomas Monjalon <<a href="mailto:thomas@monjalon.net">thomas@monjalon.net</a>><o:p></o:p> > Sent: Monday, July 3, 2023 2:17 PM<o:p></o:p> > To: Dumitrescu, Cristian; Volodymyr Fialko<o:p></o:p> > Cc: <a href="mailto:dev@dpdk.org">dev@dpdk.org</a>; Jerin Jacob Kollanukkaran; Anoob Joseph<o:p></o:p> > Subject: Re: [PATCH v3] bitmap: add scan from offset function<o:p></o:p> > <o:p></o:p> > > --------------------------------------------------------------------<o:p></o:p> > > --<o:p></o:p> > > 03/07/2023 12:56, Volodymyr Fialko:<o:p></o:p> > > > Since it's header-only library, there is issue with using __rte_intenal (appeared in v4). > > > Even if the function itself is not used directly, it get's included to the other public files. > > > It explains why other functions in this library does not have the rte_internal prefix, but the double underscores.<o:p></o:p> > > <o:p></o:p> > > What is the issue?<o:p></o:p> > <o:p></o:p> > From V4 ci build failure(<a href="http://mails.dpdk.org/archives/test-report/2023-July/421235.html">http://mails.dpdk.org/archives/test-report/2023-July/421235.html</a>):<o:p></o:p> > In file included from ../examples/ipsec-secgw/event_helper.c:6:<o:p></o:p> > ../lib/eal/include/rte_bitmap.h:645:2: error: Symbol is not public ABI<o:p></o:p> > __rte_bitmap_scan_init_at(bmp, offset);<o:p></o:p> > ^<o:p></o:p> > ../lib/eal/include/rte_bitmap.h:150:1: note: from 'diagnose_if' attribute on '__rte_bitmap_scan_init_at':<o:p></o:p> > __rte_internal<o:p></o:p> > ^~~~~~~~~~~~~~<o:p></o:p> > ../lib/eal/include/rte_compat.h:42:16: note: expanded from macro '__rte_internal' <o:p></o:p> > __attribute__((diagnose_if(1, "Symbol is not public ABI", "error"), \<o:p></o:p> > ^ ~<o:p></o:p> > 1 error generated.<o:p></o:p> <o:p> </o:p> > OK I see.<o:p></o:p> > So we should give up with __rte_internal for inline functions.<o:p></o:p> > As it is not supposed to be exposed to the applications, I think we <o:p></o:p> > can skip the __rte_experimental flag. <o:p></o:p> <o:p> </o:p> /Volodymyr<o:p></o:p> <o:p> </o:p> <div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt"> <div> <div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in"> From: Stephen Hemminger <stephen@networkplumber.org> Sent: Friday, October 4, 2024 5:04 AM To: Volodymyr Fialko <vfialko@marvell.com> Cc: dev@dpdk.org; cristian.dumitrescu@intel.com; Jerin Jacob <jerinj@marvell.com>; Anoob Joseph <anoobj@marvell.com>; thomas@monjalon.net Subject: [EXTERNAL] Re: [PATCH v5] bitmap: add scan from offset function<o:p></o:p> </div> </div> <div> Mon, 3 Jul 2023 14: 39: 08 +0200 Volodymyr Fialko <vfialko@ marvell. com> wrote: > +/** > + * Bitmap initialize internal scan pointers at the given position for the scan function. > + * > + * Note: for private/internal use,<o:p></o:p> </div> <div> ZjQcmQRYFpfptBannerStart<o:p></o:p> </div> <div> On Mon, 3 Jul 2023 14:39:08 +0200<o:p></o:p> </div> <div> <pre>Volodymyr Fialko <<a href="mailto:vfialko@marvell.com">vfialko@marvell.com</a>> wrote:<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>> +/**<o:p></o:p></pre> <pre>> + * Bitmap initialize internal scan pointers at the given position for the scan function.<o:p></o:p></pre> <pre>> + *<o:p></o:p></pre> <pre>> + * Note: for private/internal use, for public:<o:p></o:p></pre> <pre>> + * @see rte_bitmap_scan_from_offset()<o:p></o:p></pre> <pre>> + *<o:p></o:p></pre> <pre>> + * @param bmp<o:p></o:p></pre> <pre>> + * Handle to bitmap instance<o:p></o:p></pre> <pre>> + * @param pos<o:p></o:p></pre> <pre>> + * Bit position to start scan<o:p></o:p></pre> <pre>> + */<o:p></o:p></pre> <pre>> +static inline void<o:p></o:p></pre> <pre>> +__rte_bitmap_scan_init_at(struct rte_bitmap *bmp, uint32_t pos)<o:p></o:p></pre> <pre>> +{<o:p></o:p></pre> <pre>> + uint64_t *slab1;<o:p></o:p></pre> <pre><o:p> </o:p></pre> <pre>Since this exposed in a header file, needs to be internal or experimental.<o:p></o:p></pre> </div> </div> </div> </body> </html>