<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p>Hi Stephen,<br>
</p>
<div class="moz-cite-prefix">On 16/10/2024 06:29, Stephen Hemminger
wrote:<br>
</div>
<blockquote type="cite" cite="mid:20241015222938.359f7193@hermes.local">
<pre class="moz-quote-pre" wrap="">On Tue, 15 Oct 2024 17:11:43 +0000
Vladimir Medvedkin <a class="moz-txt-link-rfc2396E" href="mailto:vladimir.medvedkin@intel.com"><vladimir.medvedkin@intel.com></a> wrote:
</pre>
<blockquote type="cite">
<pre class="moz-quote-pre" wrap="">Fixes the behavior of the rte_fib_rcu_qsbr_add() function regarding its
return value to align with the existing rte_fib API.
Fixes: 96c3d06a3547 ("fib: implement RCU rule reclamation")
Signed-off-by: Vladimir Medvedkin <a class="moz-txt-link-rfc2396E" href="mailto:vladimir.medvedkin@intel.com"><vladimir.medvedkin@intel.com></a>
---
</pre>
</blockquote>
<pre class="moz-quote-pre" wrap="">
Looks good, although DPDK often uses rte_errno, it is better for this part
in fib to be consistent across rcu and non-rcu variants.
</pre>
</blockquote>
<span class="EzKURWReUAB5oZgtQNkl" data-src-align="0:1" style="white-space: pre-wrap;">I</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="2:2" style="white-space: pre-wrap;">would</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="5:9" style="white-space: pre-wrap;">prefer</span><span style="white-space: pre-wrap;"> it </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="16:5" style="white-space: pre-wrap;">to</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="22:3" style="white-space: pre-wrap;">be</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="26:15" style="white-space: pre-wrap;">consistent</span><span style="white-space: pre-wrap;"> with the </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="42:10" style="white-space: pre-wrap;">rest</span><span style="white-space: pre-wrap;"> of the </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="53:3" style="white-space: pre-wrap;">FIB</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="57:3" style="white-space: pre-wrap;">API</span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="60:1" style="white-space: pre-wrap;">.</span>
<blockquote type="cite" cite="mid:20241015222938.359f7193@hermes.local">
<pre class="moz-quote-pre" wrap="">
PS: there don't seem to be any negative tests on this function in test_fib.c
would be good to hit some of the basics.</pre>
</blockquote>
<span class="EzKURWReUAB5oZgtQNkl" data-src-align="0:8" style="white-space: pre-wrap;">maybe</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="10:1" style="white-space: pre-wrap;">I</span><span style="white-space: pre-wrap;"> didn</span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="16:2" style="white-space: pre-wrap;">'t</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="19:6" style="white-space: pre-wrap;">quite</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="26:5" style="white-space: pre-wrap;">understand</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="12:3" style="white-space: pre-wrap;">you</span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="31:1" style="white-space: pre-wrap;">,</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="33:2" style="white-space: pre-wrap;">but</span><span style="white-space: pre-wrap;"> there is basic negative </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="58:5" style="white-space: pre-wrap;">test</span><span style="white-space: pre-wrap;"> on </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="40:4" style="white-space: pre-wrap;">this</span><span style="white-space: pre-wrap;"> </span><span class="EzKURWReUAB5oZgtQNkl" data-src-align="45:7" style="white-space: pre-wrap;">function</span> (plz see
test_invalid_rcu() test)<br>
<blockquote type="cite" cite="mid:20241015222938.359f7193@hermes.local">
<pre class="moz-quote-pre" wrap="">
Reviewed-by: Stephen Hemminger <a class="moz-txt-link-rfc2396E" href="mailto:stephen@networkplumber.org"><stephen@networkplumber.org></a>
</pre>
</blockquote>
<pre class="moz-signature" cols="72">--
Regards,
Vladimir</pre>
</body>
</html>