<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Tue, Oct 29, 2024 at 7:48 AM Luca Vizzarro <<a href="mailto:Luca.Vizzarro@arm.com">Luca.Vizzarro@arm.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Patrick,<br>
<br>
On 29/10/2024 01:19, Patrick Robb wrote:<br>
> diff --git a/dts/conf.yaml b/dts/conf.yaml<br>
> index 814744a1fc..8a65a481d6 100644<br>
> --- a/dts/conf.yaml<br>
> +++ b/dts/conf.yaml<br>
> @@ -5,12 +5,24 @@<br>
> test_runs:<br>
> # define one test run environment<br>
> - dpdk_build:<br>
> - arch: x86_64<br>
> - os: linux<br>
> - cpu: native<br>
> - # the combination of the following two makes CC="ccache gcc"<br>
> - compiler: gcc<br>
> - compiler_wrapper: ccache<br>
> + # dpdk_tree: Commented out because `tarball` is defined.<br>
> <br>
> <br>
> Should this key name be extended to clarify the desired value is a path, <br>
> and whether it is absolute or relative?<br>
<br>
We could amend the key name to something more suitable if we wished. The <br>
path could be either absolute or relative, so it doesn't matter. I <br>
assume you are referring to change `dpdk_tree` to `dpdk_tree_path` and <br>
`tarball` to `tarball_path` or something similar?<br></blockquote><div><br></div><div>Yes, that was my thinking. Up to you on whether it's better or just overly wordy.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
> +1 to Dean's concerns about using the tarball without --tarball flag if <br>
> dpdk_tree is commented out and tarball is defined.<br>
<br>
As replied to Dean, this scenario currently works, and I have also just <br>
re-tested it for completeness. I need some more details to figure out <br>
what's happening.<br></blockquote><div><br></div><div>Okay, so I guess this is fine. I chatted with Dean about this today and it sounds like the workflows he was worried about do actually work (namely, copying a tarball from DTS engine to SUT) but that there is an added requirement that a flag be added (i.e. you can't just run main.py alone anymore) and it's unclear to him (and me) why this might be the case. I can try and take another look tonight, but I'm basically happy now that I know the workflows Dean was concerned about are tested and work.</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Best,<br>
Luca<br>
</blockquote></div></div>