<div dir="ltr"><div dir="ltr">On Fri, Jul 5, 2024 at 2:32 PM Nicholas Pratte <<a href="mailto:npratte@iol.unh.edu">npratte@iol.unh.edu</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Rework 'lcores' and 'memory_channels' into a new 'dpdk_config'<br>
subsection in an effort to make these attributes SUT specific; the<br>
traffic generator, more often than not, does not need this information.<br>
Ideally, if such information is needed, then it will be listed in the<br>
'traffic_generator' component in TG Node configuration. Such logic is<br>
not introduced in this patch, but the framework can be rewritten to do<br>
so without any implications of extreme effort.<br>
<br>
To make this work, use_first_core has been removed from the framework<br>
entirely in favor of doing this within the LogicalCoreListFilter object.<br>
Since use_first_core was only ever activated when logical core 0 was<br>
explicitly defined, core 0 can be removed from the list of total logical<br>
cores assuming that it was not listed within filter_specifier.<br>
<br>
This patch also removes 'vdevs' from 'system_under_test_node' and moves<br>
it into 'executions.'<br>
<br>
Bugzilla ID: 1360<br>
Signed-off-by: Nicholas Pratte <<a href="mailto:npratte@iol.unh.edu" target="_blank">npratte@iol.unh.edu</a>><br></blockquote><div><snip> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
- memory_channels: 4 # tells DPDK to use 4 memory channels<br>
- hugepages_2mb: # optional; if removed, will use system hugepage configuration<br>
- number_of: 256<br>
- force_first_numa: false<br></blockquote><div><br></div><div>Just curious, is there a reason 256 is the default value?<br><br>Reviewed-by: Dean Marx <<a href="mailto:dmarx@iol.unh.edu">dmarx@iol.unh.edu</a>> </div></div></div>