<div class="zcontentRow">Hi Stephen， >> +char zxdh_gdma_driver_name[] = "rawdev_zxdh_gdma"; >> +char dev_name[] = "zxdh_gdma"; >> + >> +uint32_t >> +zxdh_gdma_read_reg(struct rte_rawdev *dev, uint16_t queue_id, uint32_t offset) >> +{ >> + struct zxdh_gdma_rawdev *gdmadev = zxdh_gdma_rawdev_get_priv(dev); >> + uint32_t addr = 0; >> + uint32_t val = 0; >> + >> + addr = offset + queue_id * ZXDH_GDMA_CHAN_SHIFT; >> + val = *(uint32_t *)(gdmadev->base_addr + addr); >> + >> + return val; >> +} >> + >> +void >> +zxdh_gdma_write_reg(struct rte_rawdev *dev, uint16_t queue_id, uint32_t offset, uint32_t val) >> +{ >> + struct zxdh_gdma_rawdev *gdmadev = zxdh_gdma_rawdev_get_priv(dev); >> + uint32_t addr = 0; >> + >> + addr = offset + queue_id * ZXDH_GDMA_CHAN_SHIFT; >> + *(uint32_t *)(gdmadev->base_addr + addr) = val; >> +} > >This driver is made up one C file. Please make all these helper functions >and the names static. If static checkers and optimizers can work better. Thanks for your suggestion, I will check other functions. But these two functions will also be called by the test application(Not Submitted), so it is not appropriate to names static. <div unonameen="Zhang Yong10313449" unonamech="张勇10313449" class="zMailSign"><label class="sign_nameUno"></label><div class="zMailSignContent">张勇 zhangyong RCH八部/无线及算力研究院/无线及算力产品经营部RCH Dept. VIII/Wireless and Computing Product R&D Institute/Wireless and Computing Product Operation Division<a href="http://zmail.zte.com.cn/"></a></div></div><div class="zhistoryRow" style="display:block"><div class="zhistoryDes" style="width: 100%; height: 28px; line-height: 28px; background-color: #E0E5E9; color: #1388FF; text-align: center;">Original</div><div id="zwriteHistoryContainer"><div class="control-group zhistoryPanel"><div class="zhistoryHeader" style="padding: 8px; background-color: #F5F6F8;"><div>From: StephenHemminger <stephen@networkplumber.org></div><div>To: 张勇10313449;</div><div>Cc: thomas@monjalon.net <thomas@monjalon.net>;dev@dpdk.org <dev@dpdk.org>;汪勇10032886;李敏10314441;冉明10033339;</div><div>Date: 2024年11月12日 13:11</div><div>Subject: Re: [v4,1/5] raw/gdtc: introduce gdtc raw device driver</div></div><div class="zhistoryContent">On Tue, 29 Oct 2024 21:45:22 +0800 Yong Zhang <zhang.yong25@zte.com.cn> wrote: > +char zxdh_gdma_driver_name[] = "rawdev_zxdh_gdma"; > +char dev_name[] = "zxdh_gdma"; > + > +uint32_t > +zxdh_gdma_read_reg(struct rte_rawdev *dev, uint16_t queue_id, uint32_t offset) > +{ > + struct zxdh_gdma_rawdev *gdmadev = zxdh_gdma_rawdev_get_priv(dev); > + uint32_t addr = 0; > + uint32_t val = 0; > + > + addr = offset + queue_id * ZXDH_GDMA_CHAN_SHIFT; > + val = *(uint32_t *)(gdmadev->base_addr + addr); > + > + return val; > +} > + > +void > +zxdh_gdma_write_reg(struct rte_rawdev *dev, uint16_t queue_id, uint32_t offset, uint32_t val) > +{ > + struct zxdh_gdma_rawdev *gdmadev = zxdh_gdma_rawdev_get_priv(dev); > + uint32_t addr = 0; > + > + addr = offset + queue_id * ZXDH_GDMA_CHAN_SHIFT; > + *(uint32_t *)(gdmadev->base_addr + addr) = val; > +} This driver is made up one C file. Please make all these helper functions and the names static. If static checkers and optimizers can work better.</div></div></div></div> </div>