<html>
    <head>
      <base href="https://bugs.dpdk.org/">
    </head>
    <body><table border="1" cellspacing="0" cellpadding="8" class="bz_new_table">
        <tr>
          <th>Bug ID</th>
          <td><a class="bz_bug_link 
          bz_status_UNCONFIRMED "
   title="UNCONFIRMED - [dpdk-25.03] [NNT] pmd_bonded_8023ad: port start failed after set bonding lacp"
   href="https://bugs.dpdk.org/show_bug.cgi?id=1662">1662</a>
          </td>
        </tr>

        <tr>
          <th>Summary</th>
          <td>[dpdk-25.03] [NNT] pmd_bonded_8023ad: port start failed after set bonding lacp
          </td>
        </tr>

        <tr>
          <th>Product</th>
          <td>DPDK
          </td>
        </tr>

        <tr>
          <th>Version</th>
          <td>24.07
          </td>
        </tr>

        <tr>
          <th>Hardware</th>
          <td>x86
          </td>
        </tr>

        <tr>
          <th>OS</th>
          <td>Linux
          </td>
        </tr>

        <tr>
          <th>Status</th>
          <td>UNCONFIRMED
          </td>
        </tr>

        <tr>
          <th>Severity</th>
          <td>normal
          </td>
        </tr>

        <tr>
          <th>Priority</th>
          <td>Normal
          </td>
        </tr>

        <tr>
          <th>Component</th>
          <td>testpmd
          </td>
        </tr>

        <tr>
          <th>Assignee</th>
          <td>dev@dpdk.org
          </td>
        </tr>

        <tr>
          <th>Reporter</th>
          <td>songx.jiale@intel.com
          </td>
        </tr>

        <tr>
          <th>Target Milestone</th>
          <td>---
          </td>
        </tr></table>
      <p>
        <div class="bz_comment_block">
          <pre class="bz_comment_text">Environment
===========
DPDK version: e5176f23ae8b31437c3e5eb875c81f95bf3a9942 version: 25.03-rc1
OS: Ubuntu24.04.1 LTS (Noble Numbat)/6.8.0-41-generic
Compiler:  gcc version 13.2.0
Hardware platform: Intel(R) Xeon(R) Platinum 8380 CPU @ 2.30GHz
NIC hardware: NNT(82599ES 10-Gigabit SFI/SFP+ Network Connection 10fb)
NIC firmware: 
  driver: ixgbe-5.22.25
  FW: 0x000161bf

Test Setup
Steps to reproduce
==================
1. bind ports to dpdk 
./usertools/dpdk-devbind.py -b vfio-pci 0000:b1:00.0 0000:b1:00.1
2. launch testpmd
x86_64-native-linuxapp-gcc/app/dpdk-testpmd -l 1-39 -n 4 -a 0000:b1:00.0 -a
0000:b1:00.1 -- -i
3. create bonding device
port stop all
create bonding device 4 1
add bonding member 0 2
add bonding member 1 2
4. set bonding lacp
set bonding lacp dedicated_queues 2 enable
port start all
show port info all


Results: 
========
the link status of all ports is down and have some error info.

Please remove port 0 from bonding device.
Please remove port 1 from bonding device.
Configuring Port 2 (socket 1)
ETHDEV: Device with port_id=0 already stopped
ETHDEV: Device with port_id=1 already stopped
ETHDEV: Device with port_id=0 already stopped
IXGBE_INIT: ixgbe_dev_tx_queue_setup(): tx_rs_thresh + tx_free_thresh must not
exceed nb_desc. (tx_rs_thresh=32 tx_free_thresh=32 nb_desc=32 port = 0 queue=1)
BOND: member_configure_slow_queue(1726) - rte_eth_tx_queue_setup: port=0
queue_id 1, err (-22)
ETHDEV: Device with port_id=1 already stopped
IXGBE_INIT: ixgbe_dev_tx_queue_setup(): tx_rs_thresh + tx_free_thresh must not
exceed nb_desc. (tx_rs_thresh=32 tx_free_thresh=32 nb_desc=32 port = 1 queue=1)
BOND: member_configure_slow_queue(1726) - rte_eth_tx_queue_setup: port=1
queue_id 1, err (-22)
Port 2: 90:E2:BA:D5:B2:38
Checking link statuses...
Done

Expected Result:
================
The status of all ports is normal.

bad commit:
===========
commit 4da0705bf896327af062212b5a1e6cb1f1366aa5
Author: Long Wu <<a href="mailto:long.wu@corigine.com">long.wu@corigine.com</a>>
Date:   Thu Dec 26 09:26:18 2024 +0800

    net/bonding: fix dedicated queue setup

    The bonding PMD hardcoded the value of dedicated hardware Rx/Tx
    queue size as (128/512). This will cause the bonding port start
    fail if some NIC requires more Rx/Tx descriptors than the hardcoded
    number.

    Therefore, use the minimum hardware queue size of the member port
    to initialize dedicated hardware Rx/Tx queue. If obtaining the
    minimum queue size failed, use the default queue size.

    Fixes: 112891cd27e5 ("net/bonding: add dedicated HW queues for LACP
control")
    Cc: <a href="mailto:stable@dpdk.org">stable@dpdk.org</a>

    Signed-off-by: Long Wu <<a href="mailto:long.wu@corigine.com">long.wu@corigine.com</a>>
    Reviewed-by: Chaoyong He <<a href="mailto:chaoyong.he@corigine.com">chaoyong.he@corigine.com</a>>

 drivers/net/bonding/rte_eth_bond_8023ad.h |  3 +++
 drivers/net/bonding/rte_eth_bond_pmd.c    | 25 ++++++++++++++++++++++---
 2 files changed, 25 insertions, 3 deletions
          </pre>
        </div>
      </p>


      <hr>
      <span>You are receiving this mail because:</span>

      <ul>
          <li>You are the assignee for the bug.</li>
      </ul>
      <div itemscope itemtype="http://schema.org/EmailMessage">
        <div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
          
          <link itemprop="url" href="https://bugs.dpdk.org/show_bug.cgi?id=1662">
          <meta itemprop="name" content="View bug">
        </div>
        <meta itemprop="description" content="Bugzilla bug update notification">
      </div>
    </body>
</html>