<div dir="ltr">Recheck-request: iol-intel-Performance Looks like this patch was affected by an infra failure - putting in a retest request for the CI testing system.</div> <div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Sun, Apr 27, 2025 at 7:28 AM Maayan Kashani <<a href="mailto:mkashani@nvidia.com">mkashani@nvidia.com</a>> wrote: </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Queue sync operation was skipped on rule destroy. Unlike on fw wqe rule create in which both fence and notify_hw are set to true, on destroy fence was set to false causing previous queue operation to be stuck in the queue forever. Example: rule_a - HW rule, rule_b - FW WQE rule. Sequence: rule_a destroy, burst=1 (HW rule put to queue but no DB) rule_b destroy, burst=0 (FW WQE rule cmd but no queue sync) Outcome: rule_a is stuck forever in the queue - no completion. Fixes: 338aaf911665 ("net/mlx5/hws: add send FW match STE using gen WQE") Cc: <a href="mailto:stable@dpdk.org" target="_blank">stable@dpdk.org</a> Signed-off-by: Alex Vesker <<a href="mailto:valex@nvidia.com" target="_blank">valex@nvidia.com</a>> Signed-off-by: Maayan Kashani <<a href="mailto:mkashani@nvidia.com" target="_blank">mkashani@nvidia.com</a>> --- drivers/net/mlx5/hws/mlx5dr_send.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index e121c7f7ed5..d01fc7ef2ca 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -339,7 +339,7 @@ void mlx5dr_send_stes_fw(struct mlx5dr_send_engine *queue, pdn = ctx->pd_num; /* Writing through FW can't HW fence, therefore we drain the queue */ - if (send_attr->fence) + if (send_attr->fence || send_attr->notify_hw) mlx5dr_send_queue_action(ctx, queue_id, MLX5DR_SEND_QUEUE_ACTION_DRAIN_SYNC); -- 2.21.0 </blockquote></div>