<!DOCTYPE html>   <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;height:0px;max-height:0px;opacity:0;overflow:hidden;"> ping > -----Original Message----- > From: Rakesh Kudurumalla > Sent: Monday, October 21, 2024 12: 43 PM > To: Stephen Hemminger <stephen@ networkplumber. org> > Cc: ferruh. yigit@ amd. com; andrew. rybchenko@ oktetlabs. ru; ></div>   <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;max-height:0px;opacity:0;overflow:hidden;">ZjQcmQRYFpfptBannerStart</div>  <![if !((ie)|(mso))]> <div dir="ltr" lang="en" id="pfptBannervsxodf9" style="all: revert !important; display:block !important; text-align: left !important; margin:16px 0px 16px 0px !important; padding:8px 16px 8px 16px !important; border-radius: 4px !important; min-width: 200px !important; background-color: #D2D0D0 !important; background-color: #D2D0D0; border-top: 4px solid #8d8c8c !important; border-top: 4px solid #8d8c8c;"> <div id="pfptBannervsxodf9" style="all: unset !important; float:left !important; display:block !important; margin: 0px 0px 1px 0px !important; max-width: 600px !important;"> <div id="pfptBannervsxodf9" style="all: unset !important; display:block !important; visibility: visible !important; background-color: #D2D0D0 !important; color:#000000 !important; color:#000000; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-weight:bold !important; font-weight:bold; font-size:14px !important; line-height:18px !important; line-height:18px"> Prioritize security for external emails: </div> <div id="pfptBannervsxodf9" style="all: unset !important; display:block !important; visibility: visible !important; background-color: #D2D0D0 !important; color:#000000 !important; color:#000000; font-weight:normal; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-size:12px !important; line-height:18px !important; line-height:18px; margin-top:2px !important;"> Confirm sender and content safety before clicking links or opening attachments </div> </div> <div id="pfptBannervsxodf9" style="all: unset !important; float: right !important; display: block !important; display: block; margin: 0px 0px 0px 16px !important; text-align: right !important; width: fit-content !important;"> <a id="pfptBannervsxodf9" href="https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!ui3XGl_YrjX7-6H8OZ36wMSK0zI7DzqB7PRP5EkEzzLBN_bwH4w4tTxdNK5ZzWy7bWhuX9YtOG_SWbVRKjvEuIsfF5jJRKaSjsmXIzXu4bE9l2AYFaurjOLDOxa8J9yuidlP8EA$" style="all: unset !important; display: inline-block !important; text-decoration: none"> <div class="pfptPrimaryButtonvsxodf9" style="display: inline-block !important; display: inline-block; visibility: visible !important; opacity: 1 !important; color: #000000 !important; color: #000000; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-size: 14px !important; font-weight: normal !important; text-decoration: none !important; border-radius: 2px !important; padding: 7.5px 16px !important; margin: 3px 0 3px 16px !important; white-space: nowrap !important; width: fit-content !important; border: 1px solid #666666"> Report Suspicious </div> </a> </div> <div style="clear: both !important; display: block !important; visibility: hidden !important; line-height: 0 !important; font-size: 0.01px !important; height: 0px"> </div> </div> <![endif]> <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;max-height:0px;opacity:0;overflow:hidden;">ZjQcmQRYFpfptBannerEnd</div>   <html> <head> <style> #pfptBannervsxodf9 { all: revert !important; display: block !important; visibility: visible !important; opacity: 1 !important; background-color: #D2D0D0 !important; max-width: none !important; max-height: none !important } .pfptPrimaryButtonvsxodf9:hover, .pfptPrimaryButtonvsxodf9:focus { background-color: #afaeae !important; } .pfptPrimaryButtonvsxodf9:active { background-color: #8d8c8c !important; } </style>  </head><body><pre style="font-family: sans-serif; font-size: 100%; white-space: pre-wrap; word-wrap: break-word">ping > -----Original Message----- > From: Rakesh Kudurumalla > Sent: Monday, October 21, 2024 12:43 PM > To: Stephen Hemminger <stephen@networkplumber.org> > Cc: ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; > orika@nvidia.com; thomas@monjalon.net; dev@dpdk.org; Jerin Jacob > <jerinj@marvell.com>; Nithin Kumar Dabilpuram > <ndabilpuram@marvell.com>; stable@dpdk.org > Subject: RE: [EXTERNAL] Re: [PATCH v5 1/1] examples/l2fwd-jobstats: fix lock > availability > > ping > > > -----Original Message----- > > From: Rakesh Kudurumalla > > Sent: Friday, August 16, 2024 10:55 AM > > To: Stephen Hemminger <stephen@networkplumber.org> > > Cc: ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; > > orika@nvidia.com; thomas@monjalon.net; dev@dpdk.org; Jerin Jacob > > <jerinj@marvell.com>; Nithin Kumar Dabilpuram > > <ndabilpuram@marvell.com>; stable@dpdk.org > > Subject: RE: [EXTERNAL] Re: [PATCH v5 1/1] examples/l2fwd-jobstats: > > fix lock availability > > > > > > > > > -----Original Message----- > > > From: Stephen Hemminger <stephen@networkplumber.org> > > > Sent: Sunday, August 11, 2024 9:47 PM > > > To: Rakesh Kudurumalla <rkudurumalla@marvell.com> > > > Cc: ferruh.yigit@amd.com; andrew.rybchenko@oktetlabs.ru; > > > orika@nvidia.com; thomas@monjalon.net; dev@dpdk.org; Jerin Jacob > > > <jerinj@marvell.com>; Nithin Kumar Dabilpuram > > > <ndabilpuram@marvell.com>; stable@dpdk.org > > > Subject: [EXTERNAL] Re: [PATCH v5 1/1] examples/l2fwd-jobstats: fix > > > lock availability > > > > > > On Sun, 11 Aug 2024 21: 29: 57 +0530 Rakesh Kudurumalla > > <rkudurumalla@ > > > marvell. com> wrote: > Race condition between jobstats and time > > > metrics > for forwarding and flushing is maintained using spinlock. > > > > Timer metrics are not displayed ZjQcmQRYFpfptBannerStart > > > > Prioritize > > > security for external emails: > > > Confirm sender and content safety before clicking links or opening > > > attachments <https://us-phishalarm- > > > ewt.proofpoint.com/EWT/v1/CRVmXkqW!tO3Z1f8UInTa1C- > > > 9mf26T3uX73UqjtUJsBWGX-rk_dssJPGlvBi- > > > i4JJ8N0lgr7VCzhKzM0HeumhPOfiwCFlbzU$> > > > Report Suspicious > > > > > > ZjQcmQRYFpfptBannerEnd > > > On Sun, 11 Aug 2024 21:29:57 +0530 > > > Rakesh Kudurumalla <rkudurumalla@marvell.com> wrote: > > > > > > > Race condition between jobstats and time metrics for forwarding > > > > and flushing is maintained using spinlock. > > > > Timer metrics are not displayed properly due to the frequent > > > > unavailability of the lock.This patch fixes the issue by > > > > introducing a delay before acquiring the lock in the loop. This > > > > delay allows for betteravailability of the lock, ensuring that > > > > show_lcore_stats() can periodically update the statistics even > > > > when forwarding jobs are running. > > > > > > > > Fixes: 204896f8d66c ("examples/l2fwd-jobstats: add new example") > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Rakesh Kudurumalla <rkudurumalla@marvell.com> > > > > > > Would be better if this code used RCU and not a lock > > > > Currently the jobstats app uses the lock only for collecting single > > snapshot of different statistics and printing the same from main core. > > With RCU since we cannot pause the worker core to collect such a > > single snapshot, integrating RCU would need a full redesign of the > > application and would take lot of effort. </pre></body></html>