<!DOCTYPE html>   <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;height:0px;max-height:0px;opacity:0;overflow:hidden;"> > On Thu, 22 May 2025 at 19: 50, Akhil Goyal <gakhil@ marvell. com> wrote: > > > > > Hi, Akhil > > > > > > On Wed, 21 May 2025 at 20: 39, Akhil Goyal <gakhil@ marvell. com> wrote: > > > ></div>   <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;max-height:0px;opacity:0;overflow:hidden;">ZjQcmQRYFpfptBannerStart</div>  <![if !((ie)|(mso))]> <div dir="ltr" lang="en" id="pfptBanner22c336h" style="all: revert !important; display:block !important; text-align: left !important; margin:16px 0px 16px 0px !important; padding:8px 16px 8px 16px !important; border-radius: 4px !important; min-width: 200px !important; background-color: #D2D0D0 !important; background-color: #D2D0D0; border-top: 4px solid #8d8c8c !important; border-top: 4px solid #8d8c8c;"> <div id="pfptBanner22c336h" style="all: unset !important; float:left !important; display:block !important; margin: 0px 0px 1px 0px !important; max-width: 600px !important;"> <div id="pfptBanner22c336h" style="all: unset !important; display:block !important; visibility: visible !important; background-color: #D2D0D0 !important; color:#000000 !important; color:#000000; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-weight:bold !important; font-weight:bold; font-size:14px !important; line-height:18px !important; line-height:18px"> Prioritize security for external emails: </div> <div id="pfptBanner22c336h" style="all: unset !important; display:block !important; visibility: visible !important; background-color: #D2D0D0 !important; color:#000000 !important; color:#000000; font-weight:normal; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-size:12px !important; line-height:18px !important; line-height:18px; margin-top:2px !important;"> Confirm sender and content safety before clicking links or opening attachments </div> </div> <div id="pfptBanner22c336h" style="all: unset !important; float: right !important; display: block !important; display: block; margin: 0px 0px 0px 16px !important; text-align: right !important; width: fit-content !important;"> <a id="pfptBanner22c336h" href="https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!ui3X-h-YrjX7-6H8OVxa72R3WZbyaXenbpbUDjNd7ojUmAzzbsZPQzu4CbSQLs9xQisIeOGoVSY_Zfi2Npfqqo9vKLVNGrYaaAu7d8ldkSHJtng6X8IlNSeR2h0tUMa1ltrI_6U$" style="all: unset !important; display: inline-block !important; text-decoration: none"> <div class="pfptPrimaryButton22c336h" style="display: inline-block !important; display: inline-block; visibility: visible !important; opacity: 1 !important; color: #000000 !important; color: #000000; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-size: 14px !important; font-weight: normal !important; text-decoration: none !important; border-radius: 2px !important; padding: 7.5px 16px !important; margin: 3px 0 3px 16px !important; white-space: nowrap !important; width: fit-content !important; border: 1px solid #666666"> Report Suspicious </div> </a> </div> <div style="clear: both !important; display: block !important; visibility: hidden !important; line-height: 0 !important; font-size: 0.01px !important; height: 0px"> </div> </div> <![endif]> <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;max-height:0px;opacity:0;overflow:hidden;">ZjQcmQRYFpfptBannerEnd</div>   <html> <head> <style> #pfptBanner22c336h { all: revert !important; display: block !important; visibility: visible !important; opacity: 1 !important; background-color: #D2D0D0 !important; max-width: none !important; max-height: none !important } .pfptPrimaryButton22c336h:hover, .pfptPrimaryButton22c336h:focus { background-color: #afaeae !important; } .pfptPrimaryButton22c336h:active { background-color: #8d8c8c !important; } </style>  </head><body><pre style="font-family: sans-serif; font-size: 100%; white-space: pre-wrap; word-wrap: break-word">> On Thu, 22 May 2025 at 19:50, Akhil Goyal <gakhil@marvell.com> wrote: > > > > > Hi, Akhil > > > > > > On Wed, 21 May 2025 at 20:39, Akhil Goyal <gakhil@marvell.com> wrote: > > > > > > > > > Realize async mode to replace sync mode for better performance > > > > > > > > > > Zhangfei Gao (2): > > > > > compress/uadk: use async mode to replace sync mode > > > > > crypto/uadk: use async mode to replace sync mode > > > > > > > > > > drivers/compress/uadk/uadk_compress_pmd.c | 107 ++++-- > > > > > .../compress/uadk/uadk_compress_pmd_private.h | 2 +- > > > > > drivers/crypto/uadk/uadk_crypto_pmd.c | 321 +++++++++++++----- > > > > > drivers/crypto/uadk/uadk_crypto_pmd_private.h | 8 +- > > > > > 4 files changed, 318 insertions(+), 120 deletions(-) > > > > > > > > This patchset is not building for me atleast. Please fix compilation. > > > > > > > > ninja: Entering directory `./build-gcc-static' > > > > [2/31] Compiling C object > > > > drivers/libtmp_rte_compress_uadk.a.p/compress_uadk_uadk_compress_pmd.c. > > > o > > > > FAILED: > > > > drivers/libtmp_rte_compress_uadk.a.p/compress_uadk_uadk_compress_pmd.c. > > > o > > > > ccache gcc -Idrivers/libtmp_rte_compress_uadk.a.p -Idrivers -I../drivers - > > > Idrivers/compress/uadk -I../drivers/compress/uadk -Ilib/compressdev - > > > I../lib/compressdev -Ilib/eal/common -I../lib/eal/common -I. -I.. -Iconfig - > > > I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include - > > > I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include - > > > I../kernel/linux -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log - > I../lib/log - > > > Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/mbuf - > > > I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring - > > > Idrivers/bus/vdev -I../drivers/bus/vdev - > > > I/home/gakhil/up/uadk/build_x86/include -fdiagnostics-color=always - > > > D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c11 -O2 - > g - > > > include rte_config.h -Wvla -Wcast-qual -Wdeprecated -Wformat -Wformat- > > > nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes - > > > Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare - > > > Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno- > > > missing-field-initializers -D_GNU_SOURCE -fPIC -march=native -mrtm - > > > DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format- > truncation > > > -Wno-address-of-packed-member - > > > DRTE_LOG_DEFAULT_LOGTYPE=pmd.compress.uadk -MD -MQ > > > > drivers/libtmp_rte_compress_uadk.a.p/compress_uadk_uadk_compress_pmd.c. > > > o -MF > > > > drivers/libtmp_rte_compress_uadk.a.p/compress_uadk_uadk_compress_pmd.c. > > > o.d -o > > > > drivers/libtmp_rte_compress_uadk.a.p/compress_uadk_uadk_compress_pmd.c. > > > o -c ../drivers/compress/uadk/uadk_compress_pmd.c > > > > ../drivers/compress/uadk/uadk_compress_pmd.c: In function > > > ‘uadk_compress_pmd_config’: > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:35:9: error: variable > > > ‘cparams’ has initializer but incomplete type > > > > 35 | struct wd_ctx_params cparams = {0}; > > > > | ^~~~~~~~~~~~~ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:35:34: error: excess > elements > > > in struct initializer [-Werror] > > > > 35 | struct wd_ctx_params cparams = {0}; > > > > | ^ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:35:34: note: (near > > > initialization for ‘cparams’) > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:35:23: error: storage size > of > > > ‘cparams’ isn’t known > > > > 35 | struct wd_ctx_params cparams = {0}; > > > > | ^~~~~~~ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:42:42: error: > dereferencing > > > pointer to incomplete type ‘struct wd_ctx_nums’ > > > > 42 | ctx_set_num = calloc(WD_DIR_MAX, sizeof(*ctx_set_num)); > > > > | ^~~~~~~~~~~~ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:50:16: error: implicit > > > declaration of function ‘numa_allocate_nodemask’ [-Werror=implicit- > function- > > > declaration] > > > > 50 | cparams.bmp = numa_allocate_nodemask(); > > > > | ^~~~~~~~~~~~~~~~~~~~~~ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:50:16: error: nested > extern > > > declaration of ‘numa_allocate_nodemask’ [-Werror=nested-externs] > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:57:2: error: implicit > > > declaration of function ‘numa_bitmask_setall’ [-Werror=implicit-function- > > > declaration] > > > > 57 | numa_bitmask_setall(cparams.bmp); > > > > | ^~~~~~~~~~~~~~~~~~~ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:57:2: error: nested extern > > > declaration of ‘numa_bitmask_setall’ [-Werror=nested-externs] > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:60:14: error: invalid use > of > > > undefined type ‘struct wd_ctx_nums’ > > > > 60 | ctx_set_num[i].async_ctx_num = UADK_COMP_DEF_CTXS; > > > > | ^ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:62:8: error: implicit > > > declaration of function ‘wd_comp_init2_’; did you mean ‘wd_comp_init’? [- > > > Werror=implicit-function-declaration] > > > > 62 | ret = wd_comp_init2_(alg_name, SCHED_POLICY_RR, TASK_HW, > > > &cparams); > > > > | ^~~~~~~~~~~~~~ > > > > | wd_comp_init > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:62:8: error: nested extern > > > declaration of ‘wd_comp_init2_’ [-Werror=nested-externs] > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:62:50: error: ‘TASK_HW’ > > > undeclared (first use in this function) > > > > 62 | ret = wd_comp_init2_(alg_name, SCHED_POLICY_RR, TASK_HW, > > > &cparams); > > > > | ^~~~~~~ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:62:50: note: each > undeclared > > > identifier is reported only once for each function it appears in > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:63:2: error: implicit > > > declaration of function ‘numa_free_nodemask’ [-Werror=implicit-function- > > > declaration] > > > > 63 | numa_free_nodemask(cparams.bmp); > > > > | ^~~~~~~~~~~~~~~~~~ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:63:2: error: nested extern > > > declaration of ‘numa_free_nodemask’ [-Werror=nested-externs] > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:35:23: error: unused > variable > > > ‘cparams’ [-Werror=unused-variable] > > > > 35 | struct wd_ctx_params cparams = {0}; > > > > | ^~~~~~~ > > > > ../drivers/compress/uadk/uadk_compress_pmd.c: In function > > > ‘uadk_compress_pmd_close’: > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:97:3: error: implicit > > > declaration of function ‘wd_comp_uninit2’; did you mean ‘wd_comp_uninit’? > [- > > > Werror=implicit-function-declaration] > > > > 97 | wd_comp_uninit2(); > > > > | ^~~~~~~~~~~~~~~ > > > > | wd_comp_uninit > > > > ../drivers/compress/uadk/uadk_compress_pmd.c:97:3: error: nested extern > > > declaration of ‘wd_comp_uninit2’ [-Werror=nested-externs] > > > > > > I am sorry for the error. > > > > > > There are two reasons, one is using a newer uadk api, the other is > > > dependence on numa. > > > When using the old version uadk, I can reproduce a similar build > > > error, though not exactly the same. > > > And it can be solved by using a newer uadk version, at least 2.6, uadk > > > master branch does not have issues. > > > > > > a. 2.6 version exports the new api > > > b. building uadk library itself requires install numa, like yum > > > install numactl-devel > > > c. 2.6 header file +#include <numa.h>, which will be included automatically. > > > > > > Will add version dependence in the next version. > > > > Yes this is what I also suspected. > > > > But we cannot just change the version dependency without prior deprecation > notice. > > I would suggest sending a deprecation notice in this release and use it in next > release. > > > > @David/Aaron, your thoughts? > > > > > Hi, Akhil > > The two dpdk drivers are still workable with the latest uadk library. What is the meaning of latest. Latest keeps moving. DPDK documentation for ZSDA PMD should have a version tag of the external library. So when someone works on older DPDK version, it should be definite about which version of ZSDA external lib should be used. > > The uadk library is promoting the new API, which was introduced in the > recent release, so switch to the new interface. > > Do you mean add a deprecation notice in release_25_07.rst: API Changes? > And keep the patches until the 25.11 release, ie, send the patches > again in Sep? > DPDK deprecation notice need not include API changes in external libraries. We just need to notify the users about the version of ZSDA external lib is going to change in next release or so. And then we can change the code. You can refer to intel-ipsec-mb. It manages compatible external library version in dpdk docs. </pre></body></html>