<!DOCTYPE html>   <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;height:0px;max-height:0px;opacity:0;overflow:hidden;"> > > From: Andre Muezerie <andremue@ linux. microsoft. com> > > Sent: Friday, April 4, 2025 7: 18 AM > > To: Nithin Kumar Dabilpuram <ndabilpuram@ marvell. com>; Kiran Kumar > > Kokkilagadda <kirankumark@ marvell. com>;</div>   <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;max-height:0px;opacity:0;overflow:hidden;">ZjQcmQRYFpfptBannerStart</div>  <![if !((ie)|(mso))]> <div dir="ltr" lang="en" id="pfptBanner0k8x9no" style="all: revert !important; display:block !important; text-align: left !important; margin:16px 0px 16px 0px !important; padding:8px 16px 8px 16px !important; border-radius: 4px !important; min-width: 200px !important; background-color: #D2D0D0 !important; background-color: #D2D0D0; border-top: 4px solid #8d8c8c !important; border-top: 4px solid #8d8c8c;"> <div id="pfptBanner0k8x9no" style="all: unset !important; float:left !important; display:block !important; margin: 0px 0px 1px 0px !important; max-width: 600px !important;"> <div id="pfptBanner0k8x9no" style="all: unset !important; display:block !important; visibility: visible !important; background-color: #D2D0D0 !important; color:#000000 !important; color:#000000; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-weight:bold !important; font-weight:bold; font-size:14px !important; line-height:18px !important; line-height:18px"> Prioritize security for external emails: </div> <div id="pfptBanner0k8x9no" style="all: unset !important; display:block !important; visibility: visible !important; background-color: #D2D0D0 !important; color:#000000 !important; color:#000000; font-weight:normal; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-size:12px !important; line-height:18px !important; line-height:18px; margin-top:2px !important;"> Confirm sender and content safety before clicking links or opening attachments </div> </div> <div id="pfptBanner0k8x9no" style="all: unset !important; float: right !important; display: block !important; display: block; margin: 0px 0px 0px 16px !important; text-align: right !important; width: fit-content !important;"> <a id="pfptBanner0k8x9no" href="https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!ui3Vmv9YrjX7-6H8Odxarv_Zw1JD81gcd-C6xsoBvnm16iV3ibKEP2Q4vEy15LzPWnnRTe94Bc_mN96d-C_OxV3PrHQi_iudGeLpHir4nVufYToka1AcbwiIF7PX2Loxm0TVmvM$" style="all: unset !important; display: inline-block !important; text-decoration: none"> <div class="pfptPrimaryButton0k8x9no" style="display: inline-block !important; display: inline-block; visibility: visible !important; opacity: 1 !important; color: #000000 !important; color: #000000; font-family: 'Arial', sans-serif !important; font-family: 'Arial', sans-serif; font-size: 14px !important; font-weight: normal !important; text-decoration: none !important; border-radius: 2px !important; padding: 7.5px 16px !important; margin: 3px 0 3px 16px !important; white-space: nowrap !important; width: fit-content !important; border: 1px solid #666666"> Report Suspicious </div> </a> </div> <div style="clear: both !important; display: block !important; visibility: hidden !important; line-height: 0 !important; font-size: 0.01px !important; height: 0px"> </div> </div> <![endif]> <div style="display:none !important;display:none;visibility:hidden;mso-hide:all;font-size:1px;color:#ffffff;line-height:1px;max-height:0px;opacity:0;overflow:hidden;">ZjQcmQRYFpfptBannerEnd</div>   <html> <head> <style> #pfptBanner0k8x9no { all: revert !important; display: block !important; visibility: visible !important; opacity: 1 !important; background-color: #D2D0D0 !important; max-width: none !important; max-height: none !important } .pfptPrimaryButton0k8x9no:hover, .pfptPrimaryButton0k8x9no:focus { background-color: #afaeae !important; } .pfptPrimaryButton0k8x9no:active { background-color: #8d8c8c !important; } </style>  </head><body><pre style="font-family: sans-serif; font-size: 100%; white-space: pre-wrap; word-wrap: break-word">> > From: Andre Muezerie <andremue@linux.microsoft.com> > > Sent: Friday, April 4, 2025 7:18 AM > > To: Nithin Kumar Dabilpuram <ndabilpuram@marvell.com>; Kiran Kumar > > Kokkilagadda <kirankumark@marvell.com>; Sunil Kumar Kori > > <skori@marvell.com>; Satha Koteswara Rao Kottidi > > <skoteshwar@marvell.com>; Harman Kalra <hkalra@marvell.com> > > Cc: dev@dpdk.org; Andre Muezerie <andremue@linux.microsoft.com> > > Subject: [EXTERNAL] [PATCH] drivers: remove __rte_used from functions for > > compatibility with MSVC > > > > With gcc, the macro __rte_used translates to __attribute__((used)). MSVC > has > > something to the same effect, but harder to use and with some limitations > (one > > being that it cannot be used with "static"). Therefore, it makes sense to > avoid > > __rte_used ZjQcmQRYFpfptBannerStart Prioritize security for external > emails: > > Confirm sender and content safety before clicking links or opening > attachments > > <https://us-phishalarm- > <<a href="https://urldefense.proofpoint.com/v2/url?u=https-3A__us-2Dphishalarm- >">https://urldefense.proofpoint.com/v2/url?u=https-3A__us-2Dphishalarm- ></a>2D&d=DwQFAg&c=nKjWec2b6R0mOyPaz7xtfQ&r=E3SgYMjtKCMVsB- > fmvgGV3o- > g_fjLhk5Pupi9ijohpc&m=1VjiJp6BZRZ004EEbRgDWdnwVSxocf7eebwvsLHsSba > GED02QuAMX--cepxiabet&s=Xp1219TuPNnfOJWQk6-Il7LikxCZOexBfkdSm- > kmbuI&e=> > > > ewt.proofpoint.com/EWT/v1/CRVmXkqW!t83ZtR_UwpW61E99mn37ThGThaB > 6 > > gt7spCdfZvP9Yz5DLa-AKWhfbPLLmgyDnTM_FczAEE3KDso8- > > QC5MEstA0f8Xb8gLd9dJN3BVWrFMpv9DT2-yl2l$> > > Report Suspicious > > > > ZjQcmQRYFpfptBannerEnd > > With gcc, the macro __rte_used translates to __attribute__((used)). > > MSVC has something to the same effect, but harder to use and with some > > limitations (one being that it cannot be used with "static"). Therefore, it > makes > > sense to avoid __rte_used in some cases. > > > > The functions modified in this patch don't really need to use __rte_used. > > Instead, these functions can be involved in same ifdefs used in the callers. > That > > way, they are only defined when needed (when someone is actually calling > the > > function). Doing so makes the code compatible with MSVC and avoids > compiler > > warnings about functions being defined but not used. > > > > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com> > > --- > > drivers/net/cnxk/cn10k_rx_select.c | 6 +++++- > > drivers/net/cnxk/cn10k_tx_select.c | 6 ++++-- > > drivers/net/cnxk/cn20k_rx_select.c | 6 +++++- > > drivers/net/cnxk/cn20k_tx_select.c | 6 ++++-- > > drivers/net/cnxk/cn9k_rx_select.c | 6 ++++-- > > drivers/net/cnxk/cn9k_tx_select.c | 6 ++++-- > > 6 files changed, 26 insertions(+), 10 deletions(-) > > > > diff --git a/drivers/net/cnxk/cn10k_rx_select.c > > b/drivers/net/cnxk/cn10k_rx_select.c > > index fe1f0dda73..658a434d75 100644 > > --- a/drivers/net/cnxk/cn10k_rx_select.c > > +++ b/drivers/net/cnxk/cn10k_rx_select.c > > @@ -5,7 +5,9 @@ > > #include "cn10k_ethdev.h" > > #include "cn10k_rx.h" > > > > -static __rte_used void > > +#if defined(RTE_ARCH_ARM64) > > +#if !defined(CNXK_DIS_TMPLT_FUNC) > > Please change to #if defined(RTE_ARCH_ARM64) && > !defined(CNXK_DIS_TMPLT_FUNC) With the above change Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com> </pre></body></html>