<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote gmail_quote_container"><div dir="ltr" class="gmail_attr">On Wed, May 21, 2025 at 3:26 PM Dean Marx <<a href="mailto:dmarx@iol.unh.edu">dmarx@iol.unh.edu</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Add a method for validating flow rules to the testpmd shell class.<br>
Implement test case skipping for flow rules that do not pass<br>
validation.<br>
<br>
Signed-off-by: Dean Marx <<a href="mailto:dmarx@iol.unh.edu" target="_blank">dmarx@iol.unh.edu</a>><br>
---<br>
dts/framework/remote_session/testpmd_shell.py | 15 ++++<br>
dts/framework/test_run.py | 3 +<br>
dts/framework/test_suite.py | 21 ++++-<br>
dts/tests/TestSuite_flow.py | 90 +++++++++++++------<br>
4 files changed, 102 insertions(+), 27 deletions(-)<br>
<br>
diff --git a/dts/framework/remote_session/testpmd_shell.py b/dts/framework/remote_session/testpmd_shell.py<br>
index bd5f2659bd..c2c7ade60a 100644<br>
--- a/dts/framework/remote_session/testpmd_shell.py<br>
+++ b/dts/framework/remote_session/testpmd_shell.py<br>
@@ -1961,6 +1961,21 @@ def flow_create(self, flow_rule: FlowRule, port_id: int) -> int:<br>
self._logger.debug(f"Failed to create flow rule:\n{flow_output}")<br>
raise InteractiveCommandExecutionError(f"Failed to create flow rule:\n{flow_output}")<br>
<br>
+ def flow_validate(self, flow_rule: FlowRule, port_id: int) -> bool:<br>
+ """Validates a flow rule in the testpmd session.<br>
+<br>
+ Args:<br>
+ flow_rule: :class:`FlowRule` object used for validating testpmd flow rule.<br>
+ port_id: Integer representing the port to use.<br>
+<br>
+ Returns:<br>
+ Boolean representing whether rule is valid or not.<br>
+ """<br>
+ flow_output = self.send_command(f"flow validate {port_id} {flow_rule}")<br>
+ if "Flow rule validated" in flow_output:<br>
+ return True<br>
+ return False<br>
+<br>
def flow_delete(self, flow_id: int, port_id: int, verify: bool = True) -> None:<br>
"""Deletes the specified flow rule from the testpmd session.<br>
<br>
diff --git a/dts/framework/test_run.py b/dts/framework/test_run.py<br>
index 0fdc57ea9c..cf4af19e8f 100644<br>
--- a/dts/framework/test_run.py<br>
+++ b/dts/framework/test_run.py<br>
@@ -644,6 +644,9 @@ def next(self) -> State | None:<br>
return self<br>
<br>
self.result.update(Result.FAIL, e)<br>
+ except SkippedTestException as e:<br>
+ <a href="http://self.logger.info" rel="noreferrer" target="_blank">self.logger.info</a>(f"Test case execution SKIPPED: {e}")<br>
+ self.result.update(Result.SKIP, e)<br>
else:<br>
self.result.update(Result.PASS)<br>
<a href="http://self.logger.info" rel="noreferrer" target="_blank">self.logger.info</a>(f"{self.description.capitalize()} PASSED.")<br>
diff --git a/dts/framework/test_suite.py b/dts/framework/test_suite.py<br>
index e07c327b77..34e9eb54ea 100644<br>
--- a/dts/framework/test_suite.py<br>
+++ b/dts/framework/test_suite.py<br>
@@ -39,7 +39,7 @@<br>
PacketFilteringConfig,<br>
)<br>
<br>
-from .exception import ConfigurationError, InternalError, TestCaseVerifyError<br>
+from .exception import ConfigurationError, InternalError, SkippedTestException, TestCaseVerifyError<br>
from .logger import DTSLogger, get_dts_logger<br>
from .utils import get_packet_summaries, to_pascal_case<br>
<br>
@@ -411,6 +411,25 @@ def _fail_test_case_verify(self, failure_description: str) -> None:<br>
self._logger.debug(command_res.command)<br>
raise TestCaseVerifyError(failure_description)<br>
<br>
+ def verify_skip(self, condition: bool, skip_reason: str) -> None:<br></blockquote><div><br></div><div>Maybe rename to "verify_else_skip" so it is more descriptive? Up to you.</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><br></blockquote><div><br></div><div><br></div><div>Reviewed-by: Patrick Robb <<a href="mailto:probb@iol.unh.edu">probb@iol.unh.edu</a>> </div></div></div>