<html>
<head>
<base href="https://bugs.dpdk.org/">
</head>
<body><table border="1" cellspacing="0" cellpadding="8" class="bz_new_table">
<tr>
<th>Bug ID</th>
<td><a class="bz_bug_link
bz_status_UNCONFIRMED "
title="UNCONFIRMED - bonding: duplicate shadow local variables"
href="https://bugs.dpdk.org/show_bug.cgi?id=1745">1745</a>
</td>
</tr>
<tr>
<th>Summary</th>
<td>bonding: duplicate shadow local variables
</td>
</tr>
<tr>
<th>Product</th>
<td>DPDK
</td>
</tr>
<tr>
<th>Version</th>
<td>unspecified
</td>
</tr>
<tr>
<th>Hardware</th>
<td>All
</td>
</tr>
<tr>
<th>OS</th>
<td>All
</td>
</tr>
<tr>
<th>Status</th>
<td>UNCONFIRMED
</td>
</tr>
<tr>
<th>Severity</th>
<td>normal
</td>
</tr>
<tr>
<th>Priority</th>
<td>Normal
</td>
</tr>
<tr>
<th>Component</th>
<td>ethdev
</td>
</tr>
<tr>
<th>Assignee</th>
<td>dev@dpdk.org
</td>
</tr>
<tr>
<th>Reporter</th>
<td>stephen@networkplumber.org
</td>
</tr>
<tr>
<th>Target Milestone</th>
<td>---
</td>
</tr></table>
<p>
<div class="bz_comment_block">
<pre class="bz_comment_text">Building with -Wshadow flags several potential bugs in bonding:
[963/3418] Compiling C object
drivers/libtmp_rte_net_bond.a.p/net_bonding_rte_eth_bond_pmd.c.o
../drivers/net/bonding/rte_eth_bond_pmd.c: In function ‘member_start’:
../drivers/net/bonding/rte_eth_bond_pmd.c:1910:42: warning: declaration of
‘internals’ shadows a previous local [-Wshadow]
1910 | struct bond_dev_private *internals;
| ^~~~~~~~~
../drivers/net/bonding/rte_eth_bond_pmd.c:1828:34: note: shadowed declaration
is here
1828 | struct bond_dev_private *internals =
bonding_eth_dev->data->dev_private;
| ^~~~~~~~~
../drivers/net/bonding/rte_eth_bond_pmd.c: In function
‘bond_ethdev_allmulticast_disable’:
../drivers/net/bonding/rte_eth_bond_pmd.c:2914:34: warning: declaration of
‘port_id’ shadows a previous local [-Wshadow]
2914 | uint16_t port_id =
internals->members[i].port_id;
| ^~~~~~~
../drivers/net/bonding/rte_eth_bond_pmd.c:2903:18: note: shadowed declaration
is here
2903 | uint16_t port_id;
| ^~~~~~~
../drivers/net/bonding/rte_eth_bond_pmd.c: In function ‘bond_ethdev_configure’:
../drivers/net/bonding/rte_eth_bond_pmd.c:4111:26: warning: declaration of ‘i’
shadows a previous local [-Wshadow]
4111 | unsigned i;
| ^
../drivers/net/bonding/rte_eth_bond_pmd.c:3946:18: note: shadowed declaration
is here
3946 | unsigned i, j;
|
</pre>
</div>
</p>
<hr>
<span>You are receiving this mail because:</span>
<ul>
<li>You are the assignee for the bug.</li>
</ul>
<div itemscope itemtype="http://schema.org/EmailMessage">
<div itemprop="action" itemscope itemtype="http://schema.org/ViewAction">
<link itemprop="url" href="https://bugs.dpdk.org/show_bug.cgi?id=1745">
<meta itemprop="name" content="View bug">
</div>
<meta itemprop="description" content="Bugzilla bug update notification">
</div>
</body>
</html>