<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Hey Akhil,</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
I attempted to split the changes into multiple patches and added a depends-on the second patch. But automation does not seem to be picking up the patch as a dependency. Is there a process step I messed up:<br>
<br>
</div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Patch 1: <a class="OWAAutoLink elementToProof" id="LPlnkOWA0637687a-8bde-4f32-edd7-5be3c43f6d2d" href="https://patches.dpdk.org/project/dpdk/patch/20250918204411.1701035-1-svaze@qti.qualcomm.com/">
compress/zlib: support for dictionary and PDCP checksum - Patchwork</a></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Patch 2 with depends-n: <a class="OWAAutoLink elementToProof" id="LPlnkOWA86529131-e09f-537c-d631-302b16dab54f" href="https://patches.dpdk.org/project/dpdk/patch/20250918210806.1709958-1-svaze@qti.qualcomm.com/">
app/compress-perf: support dictionary files - Patchwork</a></div>
<div class="elementToProof" id="Signature">
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof">
Thanks<br>
Sameer Vaze</div>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Akhil Goyal <gakhil@marvell.com><br>
<b>Sent:</b> Tuesday, June 17, 2025 3:34 PM<br>
<b>To:</b> Sameer Vaze <svaze@qti.qualcomm.com>; Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com><br>
<b>Cc:</b> dev@dpdk.org <dev@dpdk.org><br>
<b>Subject:</b> RE: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.<br>
<br>
> compress/zlib: support PDCP checksum<br>
><br>
> compress/zlib: support zlib dictionary<br>
><br>
> compressdev: add PDCP checksum<br>
><br>
> compressdev: support zlib dictionary<br>
><br>
> Adds support to provide predefined dictionaries to zlib. Handles setting<br>
> and getting of dictionaries using zlib apis. Also includes support to<br>
> read dictionary files<br>
><br>
> Adds support for passing in and validationg 3GPP PDCP spec defined<br>
> checksums as defined under the Uplink Data Compression(UDC) feature.<br>
> Changes also include functions that do inflate or deflate specific<br>
> checksum operations.<br>
><br>
> Introduces new members to compression api structures to allow setting<br>
> predefined dictionaries<br>
><br>
> Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com><br>
<br>
Seems like multiple patches are squashed into a single patch<br>
<br>
I see that this patch has ABI breaks.<br>
We need to defer this patch for next ABI break release.<br>
Please split the patch appropriately.<br>
First patch should define the library changes.<br>
And subsequently logically broken PMD patches<br>
Followed by application patches.<br>
Ensure each patch is compilable.<br>
<br>
Since this patch is breaking ABI/API,<br>
Please send a deprecation notice to be merged in this release and<br>
Implementation for next release.<br>
<br>
Also avoid unnecessary and irrelevant code changes.<br>
<br>
</div>
</span></font></div>
</body>
</html>