<!DOCTYPE html><html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body>
<p><br>
</p>
<div class="moz-cite-prefix">On 22-09-2025 17:39, David Marchand
wrote:<br>
</div>
<blockquote type="cite" cite="mid:CAJFAV8wK8G_Y+-PTLm1J4Z9g9+5WKSGMGr=1jBrd10kqt0CLVw@mail.gmail.com">
<pre wrap="" class="moz-quote-pre">Hello,
On Mon, 22 Sept 2025 at 08:35, Vemula Venkatesh
<a class="moz-txt-link-rfc2396E" href="mailto:venkatesh.vemula@intel.com"><venkatesh.vemula@intel.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="" class="moz-quote-pre">diff --git a/drivers/net/intel/idpf/idpf_common_device.h b/drivers/net/intel/idpf/idpf_common_device.h
index 5f3e4a4fcf..9d1d7dc47c 100644
--- a/drivers/net/intel/idpf/idpf_common_device.h
+++ b/drivers/net/intel/idpf/idpf_common_device.h
@@ -44,6 +44,23 @@
(sizeof(struct virtchnl2_ptype) + \
(((p)->proto_id_count ? ((p)->proto_id_count - 1) : 0) * sizeof((p)->proto_id[0])))
+/** Macro used to help building up tables of device IDs with PCI class */
+#define RTE_PCI_CLASS(cls) \
+ .class_id = (cls), \
+ .vendor_id = RTE_PCI_ANY_ID, \
+ .device_id = RTE_PCI_ANY_ID, \
+ .subsystem_vendor_id = RTE_PCI_ANY_ID, \
+ .subsystem_device_id = RTE_PCI_ANY_ID
</pre>
</blockquote>
<pre wrap="" class="moz-quote-pre">
Don't define a macro with the RTE_PCI_ namespace in a driver.
Either this is really specific to IDPF, and this should be renamed
with a prefix reflecting this.
This macro is a huge wildcard on a pci class, which seems very specific.
Or this makes sense for other drivers and then this macro should be
moved to the pci bus driver header.</pre>
</blockquote>
<pre>Yes David, it only applies to IDPF. As per PCI document-</pre>
<pre> <a class="moz-txt-link-freetext" href="https://members.pcisig.com/document/20113">https://members.pcisig.com/document/20113</a> Table: 1.3</pre>
<pre>Is it OK to rename it: IDPF_PCI_CLASS ?</pre>
<blockquote type="cite" cite="mid:CAJFAV8wK8G_Y+-PTLm1J4Z9g9+5WKSGMGr=1jBrd10kqt0CLVw@mail.gmail.com">
<pre wrap="" class="moz-quote-pre">
</pre>
</blockquote>
</body>
</html>