<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
Hi,</div>
<div id="appendonsend"></div>
<div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0);" class="elementToProof">
<br>
</div>
<hr style="display: inline-block; width: 98%;">
<div id="divRplyFwdMsg">
<div style="direction: ltr; font-family: Calibri, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);">
<b>From:</b> Bruce Richardson <bruce.richardson@intel.com><br>
<b>Sent:</b> Tuesday, September 23, 2025 10:12 PM<br>
<b>To:</b> dev@dpdk.org <dev@dpdk.org><br>
<b>Cc:</b> Bruce Richardson <bruce.richardson@intel.com>; Xu, Rosen <rosen.xu@altera.com><br>
<b>Subject:</b> [RFC PATCH 2/6] net/ipn3ke: drop unsupported per-queue xstats</div>
<div style="direction: ltr;"> </div>
</div>
<div style="font-size: 11pt;" class="elementToProof">The ipn3ke driver does not actually report per-queue stats, it always<br>
sets the values to zero, so drop the flag causing auto-generation of<br>
these meaningless xstats.<br>
<br>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com><br>
---<br>
drivers/net/intel/ipn3ke/ipn3ke_representor.c | 11 +----------<br>
1 file changed, 1 insertion(+), 10 deletions(-)<br>
<br>
diff --git a/drivers/net/intel/ipn3ke/ipn3ke_representor.c b/drivers/net/intel/ipn3ke/ipn3ke_representor.c<br>
index feb57420c3..c5aca0ea8f 100644<br>
--- a/drivers/net/intel/ipn3ke/ipn3ke_representor.c<br>
+++ b/drivers/net/intel/ipn3ke/ipn3ke_representor.c<br>
@@ -2124,7 +2124,6 @@ ipn3ke_rpst_stats_get<br>
uint16_t port_id = 0;<br>
char *ch;<br>
int cnt = 0;<br>
- int i = 0;<br>
struct rte_afu_device *afu_dev = NULL;<br>
struct ipn3ke_hw *hw = NULL;<br>
struct ipn3ke_rpst_hw_port_stats hw_stats;<br>
@@ -2200,13 +2199,6 @@ ipn3ke_rpst_stats_get<br>
stats->oerrors = hw_stats.eth.tx_discards<br>
+ hw_stats.eth.tx_errors;<br>
stats->rx_nombuf = 0;<br>
- for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) {<br>
- stats->q_ipackets[i] = 0;<br>
- stats->q_opackets[i] = 0;<br>
- stats->q_ibytes[i] = 0;<br>
- stats->q_obytes[i] = 0;<br>
- stats->q_errors[i] = 0;<br>
- }<br>
} else {<br>
ipn3ke_rpst_read_10g_lineside_stats_registers(hw,<br>
port_id,<br>
@@ -2931,8 +2923,7 @@ ipn3ke_rpst_init(struct rte_eth_dev *ethdev, void *init_params)<br>
return -ENODEV;<br>
}<br>
<br>
- ethdev->data->dev_flags |= RTE_ETH_DEV_REPRESENTOR |<br>
- RTE_ETH_DEV_AUTOFILL_QUEUE_XSTATS;<br>
+ ethdev->data->dev_flags |= RTE_ETH_DEV_REPRESENTOR;<br>
<br>
rte_spinlock_lock(&ipn3ke_link_notify_list_lk);<br>
TAILQ_INSERT_TAIL(&ipn3ke_rpst_list, rpst, next);<br>
--<br>
2.48.1<br>
<br>
</div>
<div style="font-family: "Segoe UI", "Segoe UI Web (West European)", -apple-system, BlinkMacSystemFont, Roboto, "Helvetica Neue", sans-serif; font-size: 14.6667px; color: rgb(0, 0, 0);" class="elementToProof">
<span style="background-color: rgb(255, 255, 255);">Reviewed-by: Rosen Xu <rosen.xu@altera.com></span></div>
</body>
</html>