<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Aptos;
panose-1:2 11 0 4 2 2 2 2 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
font-size:10.0pt;
font-family:"Aptos",sans-serif;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;
mso-ligatures:none;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="en-UA" link="#0563C1" vlink="#954F72" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:12.0pt;font-family:"Calibri",sans-serif">Hi!<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:12.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:12.0pt;font-family:"Calibri",sans-serif">The patch series looks good.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:12.0pt;font-family:"Calibri",sans-serif">Only one thought from my side is about consistency between prefixes for global symbols for variables and functions.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:12.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:12.0pt;font-family:"Calibri",sans-serif">For functions, we use the prefix "nthw_*"; however, the patch series uses the prefix "ntnic_" for global variables.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:12.0pt;font-family:"Calibri",sans-serif">Will it be better to keep the same prefix for functions and variables?
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:12.0pt;font-family:"Calibri",sans-serif">If there is no strict rule, we may keep "ntnic_".<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:12.0pt;font-family:"Calibri",sans-serif"><o:p> </o:p></span></p>
<div id="mail-editor-reference-message-container">
<div>
<div>
<div>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:12.0pt">On 26.09.2025, 19:25, "Stephen Hemminger" <stephen@networkplumber.org> wrote:<o:p></o:p></span></p>
</div>
<p class="MsoNormal" style="margin-left:36.0pt"><span style="font-size:11.0pt"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:0cm;margin-right:0cm;margin-bottom:12.0pt;margin-left:36.0pt">
<span style="font-size:11.0pt">The ntnic driver in next-net is not consitent in prefixing<br>
all global symbols.<br>
<br>
Stephen Hemminger (3):<br>
net/ntnic: rename nt_log_ types<br>
net/ntnic: rename hwlock<br>
net/ntnic: make flow_lock local<br>
<br>
drivers/net/ntnic/include/create_elements.h | 2 --<br>
.../ntnic/include/stream_binary_flow_api.h | 2 +-<br>
drivers/net/ntnic/ntlog/ntlog.h | 16 +++++++-------<br>
drivers/net/ntnic/ntnic_ethdev.c | 22 +++++++++----------<br>
drivers/net/ntnic/ntnic_filter/ntnic_filter.c | 10 ++++-----<br>
5 files changed, 25 insertions(+), 27 deletions(-)<br>
<br>
-- <br>
2.47.3<o:p></o:p></span></p>
</div>
</div>
</div>
</div>
</div>
</body>
</html>