<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"> <style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style> </head> <body dir="ltr"> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof"> Hey Akhil,</div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof"> <br> </div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof"> I was able to get the changes as a series. Looks like it is now passing the CI build and test steps after Patrick fixed the traffic generator and retriggered a build. Let me know if you have any comments for the changes:<br> <br> </div> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof"> <a id="LPlnk688399" href="https://patches.dpdk.org/project/dpdk/list/?series=36214">https://patches.dpdk.org/project/dpdk/list/?series=36214</a></div> <div class="elementToProof" id="Signature"> <div style="font-family: Aptos, Aptos_EmbeddedFont, Aptos_MSFontService, Calibri, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof"> <br> </div> <div style="font-family: Calibri, Arial, Helvetica, sans-serif; font-size: 11pt; color: rgb(0, 0, 0);" class="elementToProof"> Thanks<br> Sameer Vaze</div> </div> <div id="appendonsend"></div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Sameer Vaze <svaze@qti.qualcomm.com><br> <b>Sent:</b> Friday, September 19, 2025 10:00 AM<br> <b>To:</b> Akhil Goyal <gakhil@marvell.com>; Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com><br> <b>Cc:</b> dev@dpdk.org <dev@dpdk.org><br> <b>Subject:</b> Re: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files</font> <div> </div> </div> <style type="text/css" style="display:none">  </style> <div dir="ltr"> <p style="text-align:center"><span style="background-color:#ffff00; font-size:14px; font-family:sans-serif; color:#000000"><strong>WARNING:</strong> This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.</span></p> <div> <div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:11pt; color:rgb(0,0,0)"> I don't see anything specific about creating and pushing a series : <a class="x_OWAAutoLink x_elementToProof" id="LPlnkOWA61516d4a-7fbf-f91a-c39d-791cb61e936c" href="https://doc.dpdk.org/guides/contributing/patches.html"> 9. Contributing Code to DPDK — Data Plane Development Kit 25.07.0 documentation</a>. </div> <div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:11pt; color:rgb(0,0,0)"> <br> </div> <div class="x_elementToProof" style="font-family:Aptos,Aptos_EmbeddedFont,Aptos_MSFontService,Calibri,Helvetica,sans-serif; font-size:11pt; color:rgb(0,0,0)"> The only mention to a series above seems to use the depends-on tag.</div> <div id="x_Signature"> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:11pt; color:rgb(0,0,0)"> <br> </div> <div style="font-family:Calibri,Arial,Helvetica,sans-serif; font-size:11pt; color:rgb(0,0,0)"> Thanks<br> Sameer Vaze</div> </div> <div id="x_appendonsend"></div> <hr tabindex="-1" style="display:inline-block; width:98%"> <div id="x_divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" color="#000000" style="font-size:11pt"><b>From:</b> Akhil Goyal <gakhil@marvell.com><br> <b>Sent:</b> Thursday, September 18, 2025 11:08 PM<br> <b>To:</b> Sameer Vaze <svaze@qti.qualcomm.com>; Sunila Sahu <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta <ashishg@marvell.com><br> <b>Cc:</b> dev@dpdk.org <dev@dpdk.org><br> <b>Subject:</b> RE: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files</font> <div> </div> </div> <div class="x_BodyFragment"><font size="2"><span style="font-size:11pt"> <div class="x_PlainText">WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.<br> <br> Hi Sameer,<br> > Hey Akhil,<br> ><br> > I attempted to split the changes into multiple patches and added a depends-on<br> > the second patch. But automation does not seem to be picking up the patch as a<br> > dependency. Is there a process step I messed up:<br> <br> When you have dependent patches, you should send them as a series.<br> Automation runs on the last patch in the series only.<br> Currently it is not handling depends-on tag. It is for reviewers for now.<br> <br> <br> ><br> ><br> > Patch 1: compress/zlib: support for dictionary and PDCP checksum - Patchwork<br> > <<a href="https://patches.dpdk.org/project/dpdk/patch/20250918204411.1701035-1-svaze@qti.qualcomm.com/">https://patches.dpdk.org/project/dpdk/patch/20250918204411.1701035-1-svaze@qti.qualcomm.com/</a>><br> > Patch 2 with depends-n: app/compress-perf: support dictionary files - Patchwork<br> > <<a href="https://patches.dpdk.org/project/dpdk/patch/20250918210806.1709958-1-svaze@qti.qualcomm.com/">https://patches.dpdk.org/project/dpdk/patch/20250918210806.1709958-1-svaze@qti.qualcomm.com/</a>><br> ><br> > Thanks<br> > Sameer Vaze<br> > ________________________________<br> ><br> > From: Akhil Goyal <gakhil@marvell.com><br> > Sent: Tuesday, June 17, 2025 3:34 PM<br> > To: Sameer Vaze <svaze@qti.qualcomm.com>; Sunila Sahu<br> > <ssahu@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>; Ashish Gupta<br> > <ashishg@marvell.com><br> > Cc: dev@dpdk.org <dev@dpdk.org><br> > Subject: RE: [EXTERNAL] [PATCH] app/compress-perf: support dictionary files<br> ><br> > WARNING: This email originated from outside of Qualcomm. Please be wary of<br> > any links or attachments, and do not enable macros.<br> ><br> > > compress/zlib: support PDCP checksum<br> > ><br> > > compress/zlib: support zlib dictionary<br> > ><br> > > compressdev: add PDCP checksum<br> > ><br> > > compressdev: support zlib dictionary<br> > ><br> > > Adds support to provide predefined dictionaries to zlib. Handles setting<br> > > and getting of dictionaries using zlib apis. Also includes support to<br> > > read dictionary files<br> > ><br> > > Adds support for passing in and validationg 3GPP PDCP spec defined<br> > > checksums as defined under the Uplink Data Compression(UDC) feature.<br> > > Changes also include functions that do inflate or deflate specific<br> > > checksum operations.<br> > ><br> > > Introduces new members to compression api structures to allow setting<br> > > predefined dictionaries<br> > ><br> > > Signed-off-by: Sameer Vaze <svaze@qti.qualcomm.com><br> ><br> > Seems like multiple patches are squashed into a single patch<br> ><br> > I see that this patch has ABI breaks.<br> > We need to defer this patch for next ABI break release.<br> > Please split the patch appropriately.<br> > First patch should define the library changes.<br> > And subsequently logically broken PMD patches<br> > Followed by application patches.<br> > Ensure each patch is compilable.<br> ><br> > Since this patch is breaking ABI/API,<br> > Please send a deprecation notice to be merged in this release and<br> > Implementation for next release.<br> ><br> > Also avoid unnecessary and irrelevant code changes.<br> ><br> <br> </div> </span></font></div> </div> </div> </body> </html>